Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neoletter || Form builder || Add subscription checkbox type #535

Merged

Conversation

dawgoc
Copy link
Contributor

@dawgoc dawgoc commented Jul 24, 2023

Neoletter has introduced partial (beta) support for "subscription". To make this feature compatible with the example app "Form Builder," I've implemented the first change by introducing a new checkbox type "subscription".

As the "subscription" feature is still in its development stage and not yet documented, it remains concealed for standard users. Following the approach taken during the initial stages of Form Builder, I have opted to hide the "subscription" functionality under a special environment variable.

ENABLE_NEOLETTER_FORM_BUILDER_SUBSCRIPTION_FEATURE

This approach ensures that the feature is accessible for testing and refinement while remaining hidden from regular users until it is fully prepared for deployment.

This initial pull request sets the groundwork for the integration of Neoletter subscription feature with Form Builder.

Screenshot 2023-07-24 at 14 44 39 Screenshot 2023-07-24 at 14 44 43

cc @jfienhold @7ack7

@netlify
Copy link

netlify bot commented Jul 24, 2023

👷 Deploy request for scrivito-example pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit be53e50

@apepper apepper self-assigned this Aug 8, 2023
Copy link
Contributor

@apepper apepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FEEDBACK (850ff3d)

Very nice 🚀. Thank you for your contribution!

The only thing that I would change is the order of the options. I think an order of "Accept terms", "Subscription" and "Custom" would be nicer.

@dawgoc dawgoc requested a review from apepper August 9, 2023 12:04
Copy link
Contributor

@apepper apepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (be53e50)

Nice 🚀!

@apepper apepper merged commit 691c482 into Scrivito:master Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants