Troy/image processor ext #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TroyKomodo
force-pushed
the
troy/image-processor-ext
branch
from
f96a887
to
c64c7e0
Compare
SputNikPlop
approved these changes
Feb 2, 2024
TroyKomodo
force-pushed
the
troy/image-processor-ext
branch
from
c64c7e0
to
b90d3ec
Compare
TroyKomodo
force-pushed
the
troy/image-processor-ext
branch
from
bcf9172
to
10d6eab
Compare
4w3Official
approved these changes
Apr 15, 2024
TroyKomodo
force-pushed
the
troy/image-processor-ext
branch
from
2acc020
to
fc48d0e
Compare
fix: minor fixes feat: igdb image processor fix: proto formatting feat: handle image callback fix: lint fix: push
TroyKomodo
force-pushed
the
troy/image-processor-ext
branch
from
4e43359
to
0a45f17
Compare
We have observed strange behavior with jemalloc causing segfaults within the image processor library. We ran the library with libasan and valgrind (both incompatiable with jemalloc) and we could not find any leaks or invalid memory access or double frees. However when we use jemalloc we have issues and sometimes it segfaults always deep inside jemalloc code. Since we cannot debug this with valgrind / libasan its impossible to figure out if its a problem in our code (more likely) or jemalloc (unlikely but possible), given that the bug only comes up when we use jemalloc its likely a difference in strictness of the allocator and something we are doing is wrong but the system allocator doesnt care but jemalloc does. This issue is also only present when we link directly to jemalloc + use jemalloc as the global rust allocator (so it might be an issue in the tikv-jemalloc crate). When we use jemalloc via `LD_PRELOAD` the issue isnt there.
lennartkloock
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of what you want to change here, to help the maintainers understand why we should accept this pull request. Be sure to link to the issue if it fixes a bug or resolves a feature request.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.