Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ActiveModel insert & update #132

Merged
merged 5 commits into from Sep 10, 2021
Merged

Add ActiveModel insert & update #132

merged 5 commits into from Sep 10, 2021

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Sep 7, 2021 •
edited by tyt2y3

Resolve #110 #127

@billy1624 billy1624 self-assigned this Sep 7, 2021
@billy1624 billy1624 mentioned this pull request Sep 7, 2021
Merged
@billy1624 billy1624 marked this pull request as ready for review September 9, 2021 14:16
tyt2y3
tyt2y3 reviewed Sep 9, 2021
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Please withheld the breaking change to the Updater API in this PR. Thanks

@billy1624
Copy link
Member Author

I should open another PR for the async_trait thing?

@tyt2y3
Copy link
Member

tyt2y3 commented Sep 9, 2021

I should open another PR for the async_trait thing?

Keep this PR as-is is fine.

@tyt2y3 tyt2y3 force-pushed the update-and-insert branch 2 times, most recently from ac9dc5a to c29f932 Compare September 9, 2021 15:21
@tyt2y3 tyt2y3 changed the title Change update behavior, add ActiveModel insert & update Add ActiveModel insert & update Sep 9, 2021
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 10, 2021 •
edited

I rebased onto master. @billy1624 looks good?

@billy1624
Copy link
Member Author

Looks good to me!

tyt2y3
tyt2y3 approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart one

@tyt2y3 tyt2y3 merged commit 1775ab4 into master Sep 10, 2021
@tyt2y3 tyt2y3 deleted the update-and-insert branch September 10, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement insert & update for ActiveModel
2 participants
@billy1624 @tyt2y3