Add TryFromU64 trait for DateTime<FixedOffset>.
#331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timestamp column (with time zone) generates the field with `chrono::DateTime<chrono::FixedOffset>`. Sadly, `DeriveEntityModel` macro fails because `TryFromU64` is not implemented for this type. I added the trivial implementation for `chrono::DateTime<chrono::FixedOffset>`.
billy1624
approved these changes
Nov 22, 2021
|
Hi can someone merge this into main branch? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timestamp column (with time zone) generates the field with
chrono::DateTime<chrono::FixedOffset>.Sadly,
DeriveEntityModelmacro fails becauseTryFromU64is not implemented for this type.I added the trivial implementation for
chrono::DateTime<chrono::FixedOffset>since timestamp is not convertible to u64 anyway.