Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have a universal sample schema across different examples? #29

Closed
Tracked by #34
billy1624 opened this issue Aug 4, 2022 · 4 comments · Fixed by #62
Closed
Tracked by #34

Should we have a universal sample schema across different examples? #29

billy1624 opened this issue Aug 4, 2022 · 4 comments · Fixed by #62

Comments

@billy1624
Copy link
Member

Hey @karatakis, I saw we've two examples now. One for MySQL and the other for SQLite. But I'm wondering why the first one is based on sakila sample schema while the later is based on chinook? Is there any reason behind that?

Btw... great work! :D

@karatakis
Copy link
Collaborator

I will work on replacing SQLite database.

I had some issues with sakila generating postgre SQL schema, but I will give it a try again.

@karatakis
Copy link
Collaborator

Postgres now uses sakila with this commit e4362ec

I am waiting for SeaQL/sea-schema#77 so I can use sakila on sqlite too.

@billy1624
Copy link
Member Author

I think we can work on updating SQLite example to base on sakila database.

We could depends on sea-schema's master branch at the moment and wait for the release of sea-schema v0.9.4

@karatakis
Copy link
Collaborator

https://github.com/SeaQL/seaography/tree/sqlite-sakila we wait for the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants