Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Adding metadata rpm spec file in cortx-re repo #4

Merged
merged 21 commits into from
Nov 19, 2020
Merged

Conversation

swatiseagate
Copy link
Contributor

No description provided.

@shailesh-vaidya
Copy link
Contributor

@swatiseagate - Can you create script like build-release-rpm.sh and place it in this repo. This will ease out Jenkins job creation and will be easy in migrating to GitHub Actions.

@shailesh-vaidya shailesh-vaidya added the improvement Improvement in current workflow. label Jul 9, 2020
Copy link
Contributor

@shailesh-vaidya shailesh-vaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swatiseagate Can you create script like build-release-rpm.sh and place it in this repo. This will ease out Jenkins job creation and will be easy in migrating to GitHub Actions.

Signed-off-by: Swati Magar <swati.magar@seagate.com>
@shailesh-vaidya shailesh-vaidya changed the base branch from master to main July 28, 2020 05:59
@stale
Copy link

stale bot commented Aug 13, 2020

This issue/pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@shailesh-vaidya
Copy link
Contributor

@swatiseagate Can you please update on this.

Signed-off-by: Swati magar <swati.magar@seagate.com>
@stale
Copy link

stale bot commented Aug 26, 2020

This issue/pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the auto-stale label Aug 26, 2020
@shailesh-vaidya
Copy link
Contributor

@swatiseagate Can you please take a look into this.

@stale stale bot removed the auto-stale label Aug 26, 2020
Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
@gauravchaudhari02
Copy link
Contributor

the rpm should not be called "GA". what's "GA"? correct nem of the rpm should be "cortx" followed by the exact version of the product.

I don't see a point of having that she'll script. this rpm does not report anything. it's sole purpose is to provide the version of the product and ability to easily identify this version.

Based on the above, the description should be revised. For example, see the description of redhat-release rpm. We are looking for something like this.

@shailesh-vaidya @swatiseagate, I have made the required changes to meet/resolve the above comments by @ipoddubnyy.
Could you please verify the same?

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
ipoddubnyy
ipoddubnyy previously approved these changes Nov 5, 2020
Copy link

@ipoddubnyy ipoddubnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
scripts/cortx_metarpm/build-release-metarpm.sh Outdated Show resolved Hide resolved
scripts/cortx_metarpm/build-release-metarpm.sh Outdated Show resolved Hide resolved
scripts/cortx_metarpm/cortx.spec Outdated Show resolved Hide resolved
scripts/cortx_metarpm/cortx.spec Outdated Show resolved Hide resolved
@shailesh-vaidya
Copy link
Contributor

@gauravchaudhari02 - I am testing rpm creation on my dev setup. I will add review comments if any. Meanwhile could you please address review comments from @gowthamchinna .

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
@gauravchaudhari02
Copy link
Contributor

@gowthamchinna @shailesh-vaidya, I have made requested changes. Could you please review it?

scripts/cortx_metarpm/build-release-metarpm.sh Outdated Show resolved Hide resolved
scripts/cortx_metarpm/build-release-metarpm.sh Outdated Show resolved Hide resolved
scripts/cortx_metarpm/build-release-metarpm.sh Outdated Show resolved Hide resolved
@shailesh-vaidya
Copy link
Contributor

@swatiseagate - Does this rpm place or prints rpm information similar to RELEASE.INFO file. I can see it prints rpm names with versions however its in different format than RELEASE.INFO. Let me know if we need to use some different query option.

[root@ssc-vm-1321 cortx_metarpm]# rpm -qpR /root/rpmbuild/RPMS/x86_64/CORTX-1.0.0-99-1.0.0.x86_64.rpm -p
cortx-csm_agent = 1.0.0-11_6c07634
cortx-csm_web = 1.0.0-37_5d87528
cortx-ha = 1.0.0-12_722cea9
cortx-hare = 1.0.0-26_git8e848b0.el7
cortx-libsspl_sec = 1.0.0-13_git8aa5b5d.el7
cortx-libsspl_sec-devel = 1.0.0-13_git8aa5b5d.el7
cortx-libsspl_sec-method_none = 1.0.0-13_git8aa5b5d.el7
cortx-libsspl_sec-method_pki = 1.0.0-13_git8aa5b5d.el7
cortx-motr = 1.0.0-21_git2a585e4_3.10.0_1062.el7
cortx-motr-devel = 1.0.0-21_git2a585e4_3.10.0_1062.el7
cortx-motr-tests-ut = 1.0.0-21_git2a585e4_3.10.0_1062.el7
cortx-prvsnr = 1.0.0-34_git5ed3c25_el7
cortx-prvsnr-cli = 1.0.0-34_git5ed3c25_el7
cortx-s3iamcli = 1.0.0-29_gitd8151a6
cortx-s3iamcli-devel = 1.0.0-29_gitd8151a6
cortx-s3server = 1.0.0-29_gitd8151a6_el7
cortx-sspl = 1.0.0-13_git8aa5b5d.el7
cortx-sspl-cli = 1.0.0-13_git8aa5b5d.el7
cortx-sspl-test = 1.0.0-13_git8aa5b5d.el7
python36-cortx-prvsnr = 0.36.0-1.0.0
uds-pyi = 1.0.2-1.r4.el7
udx-discovery = 0.1.2-3.el7
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadIsXz) <= 5.2-1
[root@ssc-vm-1321 cortx_metarpm]#

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
@shailesh-vaidya shailesh-vaidya merged commit fb7a208 into main Nov 19, 2020
@shailesh-vaidya shailesh-vaidya deleted the metarpm-script branch November 19, 2020 07:38
shailesh-vaidya added a commit that referenced this pull request May 12, 2021
* Adding metadata rpm spec file in cortx-re repo

* Adding metadata rpm spec file in cortx-re repo

* Changes in cortx.spec file for rpm name

Signed-off-by: Swati Magar <swati.magar@seagate.com>

* Adding build-release-metarpm.sh script

Signed-off-by: Swati magar <swati.magar@seagate.com>

* fix: shell script and description

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: metarpm script

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* fix: error handling in metarpm script

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* fix: unused var in metarpm script

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* fix: var globbing

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: edit script

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: metarpm script

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: metarpm script

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: metarpm script for rpm versioning

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: metarpm spec file for rpm versioning

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

* refactor: metarpm name

Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>

Co-authored-by: Gaurav Chaudhari <gaurav.chaudhari@seagate.com>
Co-authored-by: Shailesh Vadiya <shailesh.vaidya@seagate.com>
Co-authored-by: mukul-seagate11 <mukul.malhotra@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement Improvement in current workflow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants