This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
Update README.md #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shailesh-vaidya
approved these changes
Jun 22, 2020
gauravchaudhari02
pushed a commit
that referenced
this pull request
Jun 25, 2020
* Update third_party/mero from branch 'master'
to 1c6c4288dcfb7bb7ff52a8befc9b3b038b04c4e1
- EOS-9485 clovis: m0_panic at m0_list_link_fini
This patch addresses a panic at m0_list_link_fini in clovis_confc_init()
backtrace:
#0 0x00007fddea3514fb in raise () from /lib64/libpthread.so.0
#1 0x00000000005580af in s3_terminate_fatal_handler (signum=6) at server/s3_daemonize_server.cc:81
#2 <signal handler called>
#3 0x00007fdde758c377 in raise () from /lib64/libc.so.6
#4 0x00007fdde758da68 in abort () from /lib64/libc.so.6
#5 0x00007fdde9417d2d in m0_arch_panic (c=c@entry=0x7fdde9887760 <__pctx.4606>, ap=ap@entry=0x7fff747de1b8)
at lib/user_space/uassert.c:129
#6 0x00007fdde9408264 in m0_panic (ctx=ctx@entry=0x7fdde9887760 <__pctx.4606>) at lib/assert.c:50
#7 0x00007fdde940ba4d in m0_list_link_fini (link=<optimized out>) at lib/list.c:177
#8 0x00007fdde940f682 in m0_tlink_fini (d=d@entry=0x7fdde9886ac0 <clink_tl>, obj=obj@entry=0xf25f69e8) at lib/tlist.c:85
#9 0x00007fdde94092f4 in clink_tlink_fini (amb=0xf25f69e8) at lib/chan.c:59
#10 m0_clink_fini (link=link@entry=0xf25f69e8) at lib/chan.c:209
#11 0x00007fdde9356bba in clovis_confc_init (m0c=0xf25f3730) at clovis/clovis_init.c:963
#12 clovis_initlift_confc (mach=0xf25fcad8) at clovis/clovis_init.c:1008
#13 0x00007fdde947891c in state_set (mach=0xf25fcad8, state=5, rc=<optimized out>) at sm/sm.c:455
#14 0x00007fdde9357aec in clovis_initlift_move_next_floor (m0c=m0c@entry=0xf25f3730) at clovis/clovis_init.c:365
#15 0x00007fdde9358220 in m0_clovis_init (m0c_p=0x6bf020 <clovis_instance>, conf=0x6beb80 <clovis_conf>, init_m0=<optimized out>)
at clovis/clovis_init.c:1562
#16 0x0000000000492912 in init_clovis () at server/clovis_common.cc:106
#17 0x00000000004898b6 in main (argc=<optimized out>, argv=<optimized out>) at server/s3server.cc:868
In clovis_confc_init() if anything fails it moves to the cleanup code, where it
was observed that m0_clink_del_lock() call was missing for m0c->m0c_conf_ready_async
before m0_clink_fini() call for the same.
To solve the panic, m0_clink_del_lock(&m0c->m0c_conf_ready_async) is added.
Change-Id: I085902edab652b55df6dc42723800fc8f5cb7c6a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codacy badge added in README file