Feat/apiv2 update #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating csi.Snapshot object from API response, earlier versions used objectType == 'snapshots'. Now use objectName == 'snapshot' instead. Also use the timestamp object returned by the api lib directly instead of generating it from a string.
… code restore and update previously unmapped device discovery check
jskazinski
requested changes
Oct 11, 2023
seagate-chris
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the new version of api-lib, utilizing the /pkg/v1 library, shown in go.mod as v1.0.18.
It rebases the original "apiv2" branch onto main, and then adds a few bug fixes.
Bug fixes: