-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beam search #95
Add beam search #95
Conversation
@SeanNaren - do you notice anything in here that would break training? I consistently get OOM errors during
Perhaps something with the new BatchSoftmax layer? I've tried commenting out large swaths but it still seems to OOM. |
Hey man its definitely involving the new batch softmax layer i think, but the behaviour is really strange, will be digging a little further into it. |
I was referencing pytorch/pytorch#1020 in the implementation of that module. |
Fixed it. Accidentally omitted the final transform when in training mode. |
Working through the kenlm integration now. |
FYI this is a thing. |
@ryanleary nice catch :) |
@SeanNaren it may be best to consider this experimental still, but I think it's probably safe to merge. |
Thanks a lot for this! |
This is a WIP integration of beam search based on my port of the ctc beam decoder in tensorflow. Will address #86.
Remaining:
If you want to test it out, you will need to manually install my pytorch_ctc bindings: https://github.com/ryanleary/pytorch-ctc