subStrings: is deprecated in Pharo 5 #844

marschall · 2015-07-14T10:37:45Z

subStrings: is deprecated in Pharo 5, they recommend #substrings:
-> the usual, check all platforms and Pharo versions, check all senders, write transformation rule or add it to Grease

Uko · 2016-06-10T16:16:38Z

substrings: is present in pharo 3 and 4, not present in squeak. Can anyone check gemstone?

dalehenrich · 2016-06-10T17:05:48Z

substrings: is not present in GemStone, we have substrings and subStrings, so subStrings: is a new one ... I suppose I could add substrings: to the base or it could be done via Grease ... I prefer that it be added to Grease, since that will ensure that the new method gets included for Seaside ...

jbrichau · 2016-07-03T08:55:46Z

@dalehenrich subStrings: is in the Squeak package on CharacterCollection in GemStone. There is a Grease test for it, so it should work fine. I suppose we can add substrings: to Grease as an alias for subStrings:, but would it not make sense to add it to the Squeak package (or maybe a Pharo package) just like what we did for when includesSubstring: was renamed to includesSubString: in Pharo 3?

The method comment in Grease mentions that subStrings: is ANSI, btw.

dalehenrich · 2016-07-03T14:05:46Z

@jbrichau either way works fine ... Grease is part of the "GsDevKit_home base" so either way the method will show up in the standard image .... I don't think the Pharo package is loaded by default, so it would be an extra dependency for Seaside if we put it there (Seaside32 doesn't currently depend upon the pharo compat package). The squeak package is pretty fragmented right now so it would mean adding it to each of the different packages ... certainly doable, but a wrapper in Grease would be the simplest:)

If it is ANSI it might just show up in 3.2.16 and 3.3.2 "on it's own" and I'll find out on Tuesday or later this week ...

marschall · 2016-08-21T15:03:46Z

For portability I removed all of your #subStrings: and #substrings: senders and directed them to a class side method in GRPlatform. This method is optimised for our use cases and in these cases allocates a lot less.

The only senders left are tests for ANSI and #subStrings: is in ANSI 5.7.10 so I'll leave those in.

Name: Seaside-Core-pmm.871
Author: pmm
Time: 21 August 2016, 4:51:52.955655 pm
UUID: e48bbc7c-53e4-4d79-80f9-fc755db59a6b
Ancestors: Seaside-Core-pmm.870