Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show console on each invokation #124

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

matwachich
Copy link
Contributor

Get rid of console window appearing on Windows.

Get rid of console window appearing on Windows
@SebastiaanKlippert
Copy link
Owner

Thanks for your input.

To be honest I never really tested this on Windows. And as you can see in the tests that now ran, they fail on any other OS.
If you can split your code into a Windows and non-Windows source file, with a build constraint like //go:build windows and probably a !windows variant, I can test it on Windows later.
I might even add a Windows Github action then.

@matwachich
Copy link
Contributor Author

Please check

@SebastiaanKlippert SebastiaanKlippert merged commit 65e9c49 into SebastiaanKlippert:master Jun 23, 2024
1 of 2 checks passed
@SebastiaanKlippert
Copy link
Owner

I merged it, will add a tag later, have not tested properly in Windows, so let's give it a few days before it becomes the new release.
Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants