Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental extractor with SWC #25

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

radu2147
Copy link

@radu2147 radu2147 commented Jan 3, 2024

This PR continues the work on this, by fixing the proper spacing rules for JSX, as well as adding plurals and a visitor for the import statements. Notes about this:

  • When we encounter nodes with text that have min and max as prefix (Sometimes they should get converted to _min.. sometimes not, I did not investigate too much into this, but if you have any idea let me know, or I will look at it more thoroughly)
  • There are still some issues with plurals as if the value of a prop of plural jsx component is a JSX Trans node (e.g. <SelectOrdinal other={<T>something</T>} />), it seems that it will add the string inside the Trans node to the extracted strings as well, although it shouldn't. I will investigate it, but it's a minor case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants