feat: Add support for bottomAppBarTheme in MiraiTheme
#135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@i-asimkhan Can you resolve these conflicts? Also please check and test the PR again. I can see some unwanted changes in the PR. |
* main: Secondary color for light and dark themes are changed for mirai_gallery Secondary color changed and default values are removed in light/dark theme Renamed `MiraiFloatingActionThemeData` to `MiraiFloatingActionButtonThemeData` and removed example theme comp from light theme Added `iconColor` and `disabledIconColor` in mirai button style Removed TextButtonThemeData wrapper on button Removed app-bar theme from light-theme example and icon theme irrelevant values causing color disruption Fixed file naming misspelled word for `overlay` in mirai sustem ui overly Added iconTheme and actionIconTheme values in MIrai app-bar theme data Fix code formatting Updated floating action button example jsons. Added floating action button theme parser in mirai/parsers Modified example json for text theme data values Added mirai text button theme data parser in mirai/parsers Updated `appBarTheme` values for icon theme in parser and example Added basic structure for appbar theme in `MiraiTheme` # Conflicts: # examples/mirai_gallery/assets/json/example_light_theme.json # packages/mirai/lib/src/parsers/mirai_theme/mirai_theme.dart # packages/mirai/lib/src/parsers/mirai_theme/mirai_theme.freezed.dart # packages/mirai/lib/src/parsers/mirai_theme/mirai_theme.g.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for
bottomAppBarThemeinMiraiThemeRelated Issues
Closes #126
Type of Change