Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Revamp Mirai Form to add form validation, getting form values and submitting Form #266

Merged
merged 12 commits into from
Feb 27, 2024

Conversation

divyanshub024
Copy link
Contributor

@divyanshub024 divyanshub024 commented Feb 25, 2024

Description

This PR revamp the Mirai form. It adds the following abilities.

  • Form Validation
  • Fetching values from TextFormField
  • Calling Network API on Submit

# Conflicts:
#	examples/mirai_gallery/assets/json/form_example.json
#	packages/mirai/lib/src/action_parsers/mirai_request_action/mirai_request_action_parser.dart
#	packages/mirai/lib/src/framework/mirai.dart
#	packages/mirai/lib/src/network/mirai_network.dart
i-asimkhan
i-asimkhan previously approved these changes Feb 27, 2024
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!!

@divyanshub024 divyanshub024 changed the title feat: Revamp Mirai Form feat: Revamp Mirai Form to add form validation, getting form values and submitting Form Feb 27, 2024
Copy link
Contributor

@i-asimkhan i-asimkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!

@i-asimkhan i-asimkhan merged commit 8e4b908 into main Feb 27, 2024
3 checks passed
@i-asimkhan i-asimkhan deleted the dv/form branch February 27, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants