Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Email notifcations for qtrly report status changes #2764

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

atGit2021
Copy link
Contributor

@atGit2021 atGit2021 commented Mar 3, 2023

┆Issue is synchronized with this Monday item by Unito

@atGit2021 atGit2021 requested a review from CarsonF as a code owner March 3, 2023 21:03
@atGit2021 atGit2021 self-assigned this Mar 3, 2023
@CarsonF
Copy link
Member

CarsonF commented Mar 3, 2023

The lint errors are from a recent formatting change affecting the entire codebase #2763

If you just rebase and lint it should grab them.

Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarsonF - On to you.

src/components/progress-report/workflow/transitions.ts Outdated Show resolved Hide resolved
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Progress @atGit2021! 💪

@sethmcknight sethmcknight linked an issue Mar 8, 2023 that may be closed by this pull request
@atGit2021 atGit2021 force-pushed the 2729⁃QR-Email-notifications branch from fee6be3 to 6663fa6 Compare March 23, 2023 17:22
Copy link
Contributor

@bryanjnelson bryanjnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes look good, sir!

@atGit2021 atGit2021 requested a review from CarsonF March 27, 2023 14:49
@atGit2021 atGit2021 force-pushed the 2729⁃QR-Email-notifications branch from ee51619 to 507bef6 Compare April 6, 2023 21:53
@atGit2021 atGit2021 requested a review from CarsonF April 19, 2023 17:28
@CarsonF CarsonF force-pushed the 2729⁃QR-Email-notifications branch from e4a1c64 to 12867ca Compare April 24, 2023 16:08
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @atGit2021! I just did some last 10% polish. This was a huge task, great job 🎉

@atGit2021 atGit2021 force-pushed the 2729⁃QR-Email-notifications branch from 12867ca to 8a83b3c Compare April 24, 2023 17:24
@atGit2021 atGit2021 merged commit a961123 into develop Apr 24, 2023
@atGit2021 atGit2021 deleted the 2729⁃QR-Email-notifications branch April 24, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR - Email notifications
3 participants