Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated short-lived downloadUrl field #3061

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

CarsonF
Copy link
Member

@CarsonF CarsonF commented Jan 24, 2024

No longer used now: SeedCompany/cord-field#1511

┆Issue is synchronized with this Monday item by Unito

Copy link

github-actions bot commented Jan 24, 2024

🗞 GraphQL Summary

View schema changes
@@ -1702,11 +1702,8 @@
   The user who created this node.
   For files, this is the user who uploaded the first version of the file.
   """
   createdBy: User!
-
-  """A direct url to download the file"""
-  downloadUrl: URL! @deprecated(reason: "Use `url` instead.\n\nNote while this url is anonymous, the new field, `url` is not.")
   id: ID!
   media: Media
   mimeType: String!
   modifiedAt: DateTime!
@@ -1835,11 +1832,8 @@
   The user who created this node.
   For files, this is the user who uploaded the first version of the file.
   """
   createdBy: User!
-
-  """A direct url to download the file version"""
-  downloadUrl: URL! @deprecated(reason: "Use `url` instead.\n\nNote while this url is anonymous, the new field, `url` is not.")
   id: ID!
   media: Media
   mimeType: String!
 

🚨 Breaking Changes

  • File.downloadUrl was removed.
  • FileVersion.downloadUrl was removed.

@CarsonF CarsonF changed the base branch from develop to tests/real-file-handling May 22, 2024 16:16
@CarsonF CarsonF marked this pull request as ready for review May 22, 2024 16:18
@CarsonF CarsonF requested a review from a team May 22, 2024 16:18
Copy link
Member

@andrewmurraydavid andrewmurraydavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

Base automatically changed from tests/real-file-handling to develop May 22, 2024 16:41
@CarsonF CarsonF merged commit 60f22ea into develop May 22, 2024
15 checks passed
@CarsonF CarsonF deleted the drop-download-url branch May 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants