Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File.downloadUrl -> url #1511

Merged
merged 4 commits into from
Jan 24, 2024
Merged

File.downloadUrl -> url #1511

merged 4 commits into from
Jan 24, 2024

Conversation

brentkulwicki
Copy link
Contributor

@brentkulwicki brentkulwicki commented Jan 18, 2024

This removes downloadUrl for url and refactors some of the things no longer necessary because of this update.

This is related to Monday ticket 5130559360

Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @brentkulwicki!

src/components/files/hooks/DownloadFile.graphql Outdated Show resolved Hide resolved
src/components/files/FilePreview/PreviewNotSupported.tsx Outdated Show resolved Hide resolved
src/components/files/FilePreview/FilePreview.tsx Outdated Show resolved Hide resolved
src/components/files/FileActions/FileActionsMenu.tsx Outdated Show resolved Hide resolved
src/components/files/FileActions/FileActionsMenu.tsx Outdated Show resolved Hide resolved
src/components/files/FileActions/FileActionsContext.tsx Outdated Show resolved Hide resolved
@brentkulwicki brentkulwicki changed the title updates downloadUrl to url and other refactors surrounding that Updates downloadUrl to url and other refactors surrounding that Jan 22, 2024
@CarsonF CarsonF changed the title Updates downloadUrl to url and other refactors surrounding that File.downloadUrl -> url Jan 23, 2024
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brentkulwicki looks great. I'm going to wait a hot sec (day) before merging.

src/components/files/FileActions/FileActionsContext.tsx Outdated Show resolved Hide resolved
@CarsonF CarsonF merged commit b3c08d2 into develop Jan 24, 2024
3 checks passed
@CarsonF CarsonF deleted the update-file-url branch January 24, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants