20220913 GRO-DROP-fix - master branch #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in #50, trying to run `./scripts/cm4_lan7800.sh` results in a build failure because `GRO_DROP` is not declared. Searching https://linux-commits-search.typesense.org for `GRO_DROP` reveals that it has been removed: torvalds/linux@38f7b44 Because `GRO_DROP` can now never be returned, the "GRO packet dropped" debug message can never be produced. The simplest fix is to remove the check and implicitly ignore the content of `gro_result`. After making that change: ``` $ sudo ./scripts/cm4_lan7800.sh Installed: /usr/src/linux-headers-5.15.61-v8+ make: Entering directory '/usr/src/linux-headers-5.15.61-v8+' CC [M] /home/pi/seeed-linux-dtoverlays/modules/lan7800/lan78xx.o LD [M] /home/pi/seeed-linux-dtoverlays/modules/lan7800/lan7800.o MODPOST /home/pi/seeed-linux-dtoverlays/modules/lan7800/Module.symvers CC [M] /home/pi/seeed-linux-dtoverlays/modules/lan7800/lan7800.mod.o LD [M] /home/pi/seeed-linux-dtoverlays/modules/lan7800/lan7800.ko make: Leaving directory '/usr/src/linux-headers-5.15.61-v8+' '/home/pi/seeed-linux-dtoverlays/modules/lan7800/lan7800.ko' -> '/lib/modules/5.15.61-v8+/extra/seeed/lan7800.ko' ------------------------------------------------------ Please reboot your device to apply all settings Enjoy! ------------------------------------------------------ ``` Fixes #50. Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
|
It's glad to see the fix code here. Thank you so much for your contribution. |
|
You are welcome. Open source! Everyone can help. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #50, trying to run
./scripts/cm4_lan7800.shresults in a build failure becauseGRO_DROPis not declared.Searching https://linux-commits-search.typesense.org for
GRO_DROPreveals that it has been removed:torvalds/linux@38f7b44
Because
GRO_DROPcan now never be returned, the "GRO packet dropped" debug message can never be produced. The simplest fix is to remove the check and implicitly ignore the content ofgro_result.After making that change:
Fixes #50.
Signed-off-by: Phill Kelley 34226495+Paraphraser@users.noreply.github.com