Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vikas/parameter doc #1005

Merged
merged 2 commits into from Jan 2, 2024
Merged

Vikas/parameter doc #1005

merged 2 commits into from Jan 2, 2024

Conversation

vikaskurapati
Copy link
Contributor

Moved k away from kVec to avoid confusion and added k in documentation for clarity

Shifted k away from kVec
Added k for acoustic travelling wave with ITM test case in documentation
Copy link
Contributor

@sebwolf-de sebwolf-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3adc885) 13.93% compared to head (103cabb) 13.93%.

❗ Current head 103cabb differs from pull request most recent head d7c80e5. Consider uploading reports for the commit d7c80e5 to get more accurate results

Files Patch % Lines
src/Initializer/InputParameters.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   13.93%   13.93%           
=======================================
  Files         256      256           
  Lines       14726    14726           
=======================================
  Hits         2052     2052           
  Misses      12674    12674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vikaskurapati vikaskurapati added this pull request to the merge queue Jan 2, 2024
Merged via the queue into master with commit a2a6e6a Jan 2, 2024
3 of 5 checks passed
@davschneller davschneller deleted the vikas/parameter-doc branch January 16, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants