Moved device initialization to the very beginning #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also * Updated reference to device * applied formatting to `SeisSol.cpp`, `SeisSol.h` and `main.cpp` * edited info printing in `ElementWiseBuilder.hpp`
davschneller
reviewed
Jun 8, 2023
| @@ -35,8 +35,9 @@ class ElementWiseBuilder : public ReceiverBasedOutputBuilder { | |||
| const auto numFaultElements = meshReader->getFault().size(); | |||
| const auto numSubTriangles = faultRefiner->getNumSubTriangles(); | |||
|
|
|||
| logInfo(localRank) << "CPP: Initialising Fault output. " | |||
| << "Number of sub-triangles: " << numSubTriangles; | |||
| logInfo(localRank) << "Initialising Fault output." | |||
There was a problem hiding this comment.
This may be a more general question... British or American spelling?
There was a problem hiding this comment.
Changed to Initializing
| case utils::Args::Success: | ||
| break; | ||
| break; | ||
| } | ||
|
|
||
| // Initialize the ASYNC I/O library | ||
| if (!m_asyncIO.init()) |
| */ | ||
| void setMeshReader(seissol::geometry::MeshReader* meshReader) { | ||
| if (m_meshReader != 0L) | ||
| logError() << "Mesh reader already initialized"; |
There was a problem hiding this comment.
{logError() << "Mesh reader already initialized";}
src/SeisSol.h
Outdated
| * Set the mesh reader | ||
| */ | ||
| void setMeshReader(seissol::geometry::MeshReader* meshReader) { | ||
| if (m_meshReader != 0L) |
There was a problem hiding this comment.
!= nullptr
(maybe longer-term—not necessarily this PR—make a managed pointer?)
| int main(int argc, char* argv[]) | ||
| { | ||
| LIKWID_MARKER_INIT; | ||
| #ifdef ACL_DEVICE |
There was a problem hiding this comment.
Merge with the #if from above? I.e.
#ifdef ACL_DEVICE
#ifdef USE_MPI
MPI::mpi.bindAcceleratorDevice();
#endif
device::DeviceInstance& device = device::DeviceInstance::getInstance();
device.api->initialize();
device.api->allocateStackMem();
#endif
or so?
|
@davschneller thanks for the review. In |
davschneller
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
SeisSol.cpp,SeisSol.handmain.cppElementWiseBuilder.hpp