Update filesystem.h #909
Merged
Update filesystem.h #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix in std::experimental::filesystem
davschneller
reviewed
Aug 1, 2023
There was a problem hiding this comment.
If we really want to check if a directory exists, then we may have to check if it's a directory in the first place as well. Cf. https://stackoverflow.com/a/24544128
(if that doesn't matter here—then maybe directoryExists is not the best-descriptive name for the method)
davschneller
approved these changes
Aug 2, 2023
|
Thanks for merging! In general, your idea is correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix in std::experimental::filesystem