Install SeisSol into bin and lib dirs #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we could also think of either merging the libraries into the binary longer term (if that's feasible), or do the opposite: extract all code into a library and have slim binaries for proxy and SeisSol proper. |
krenzland
approved these changes
Oct 10, 2023
|
@ravil-mobile were there any concerns with keeping the SYCL and GPU-compiled parts separate from the SeisSol executable like that? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts the SeisSol binaries in the bin dir, and libraries like the general offloading etc. into the lib dir. The libraries are labeled appropriately to match potential different SeisSol builds.
The launch script is placed into share.