Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust tensor sizes to fix plasticity error #985

Merged
merged 3 commits into from Nov 2, 2023

Conversation

davschneller
Copy link
Contributor

Fixes #984 . Also, we remove references to NUMBER_OF_ALIGNED_BASIS_FUNCTIONS and replace them with the proper tensor sizes, to avoid potential future errors.

@davschneller
Copy link
Contributor Author

However, note that I'm still not super happy with how the plasticity kernel looks at the moment (and it's hard-wired to an elastic setup)—we directly access the arrays; maybe it's more useful to copy them using tensor initializers, in case the structure changes in the future, but maybe that'll not be a problem... We'll see.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #985 (01e46d2) into master (73288b7) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 01e46d2 differs from pull request most recent head aa0c3ac. Consider uploading reports for the commit aa0c3ac to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #985   +/-   ##
=======================================
  Coverage   14.35%   14.35%           
=======================================
  Files         253      253           
  Lines       14251    14250    -1     
=======================================
  Hits         2046     2046           
+ Misses      12205    12204    -1     
Files Coverage Δ
src/Initializer/LTS.h 0.00% <ø> (ø)
src/ResultWriter/EnergyOutput.cpp 0.00% <ø> (ø)
src/Solver/time_stepping/TimeCluster.h 0.00% <0.00%> (ø)
src/Kernels/Plasticity.cpp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Thomas-Ulrich Thomas-Ulrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see nevertheless my comment (not related with the PR)

src/Kernels/Plasticity.cpp Outdated Show resolved Hide resolved
@davschneller davschneller added this pull request to the merge queue Nov 2, 2023
Merged via the queue into master with commit 47477bb Nov 2, 2023
3 of 5 checks passed
@davschneller davschneller deleted the davschneller/fix-plasticity-arrays branch November 2, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

off-fault plasticity is broken since #963
3 participants