Throw an exception on invalid level name

Seldaek · Nov 14, 2012 · b23cfd3 · b23cfd3
1 parent bcb51e0
commit b23cfd3
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/src/Monolog/Logger.php b/src/Monolog/Logger.php
@@ -322,6 +322,10 @@ public function addEmergency($message, array $context = array())
      */
     public static function getLevelName($level)
     {
+        if (!isset(static::$levels[$level])) {
+            throw new \InvalidArgumentException('Level "'.$level.'" is not defined, use one of: '.implode(', ', array_keys(static::$levels)));
+        }
+
         return static::$levels[$level];
     }
 

diff --git a/tests/Monolog/LoggerTest.php b/tests/Monolog/LoggerTest.php
@@ -25,6 +25,23 @@ public function testGetName()
         $this->assertEquals('foo', $logger->getName());
     }
 
+    /**
+     * @covers Monolog\Logger::getLevelName
+     */
+    public function testGetLevelName()
+    {
+        $this->assertEquals('ERROR', Logger::getLevelName(Logger::ERROR));
+    }
+
+    /**
+     * @covers Monolog\Logger::getLevelName
+     * @expectedException InvalidArgumentException
+     */
+    public function testGetLevelNameThrows()
+    {
+        Logger::getLevelName(5);
+    }
+
     /**
      * @covers Monolog\Logger::__construct
      */