Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document and test behaviour around NaN #1346

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Document and test behaviour around NaN #1346

merged 5 commits into from
Aug 24, 2023

Conversation

adriangonz
Copy link
Contributor

Fixes #1154

Changelog

  • Add docs around NaN behaviour
  • Extend Numpy and Pandas codecs to handle NaNs (only for FP* datatypes)

vtaskow
vtaskow requested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@vtaskow vtaskow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not too sure about some aspects. Other comments are just nits.

mlserver/codecs/numpy.py Show resolved Hide resolved
tests/codecs/test_numpy.py Show resolved Hide resolved
docs/user-guide/content-type.md Show resolved Hide resolved
tests/codecs/test_numpy.py Outdated Show resolved Hide resolved
tests/codecs/test_pandas.py Show resolved Hide resolved
tests/codecs/test_pandas.py Show resolved Hide resolved
vtaskow
vtaskow approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@vtaskow vtaskow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your comments make sense. 👍

tests/codecs/test_numpy.py Show resolved Hide resolved
@adriangonz adriangonz merged commit be8bab5 into SeldonIO:master Aug 24, 2023
27 checks passed
@adriangonz adriangonz deleted the docs-nan branch August 24, 2023 15:28
This was referenced Sep 5, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklaise jklaise jklaise left review comments

@vtaskow vtaskow vtaskow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for NaN in np.ndarray codec?
3 participants
@adriangonz @jklaise @vtaskow