Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Lock GitHub runners' OS #1765

Merged
merged 5 commits into from
May 30, 2024
Merged

Conversation

jesse-c
Copy link
Member

@jesse-c jesse-c commented May 16, 2024

This was motivated by our macOS jobs failing [2] because colima is missing. It looks like this is because the latest versions of the macOS runner no longer have colima installed by default [1].

colima is now explicitly installed. The incompatible --network-driver argument for this version of colima has been removed as well.

Since macOS isn't used for PRs, I had temporarily disabled that check to see the actions run. For seeing the results, you'll need to look at previous runs for this PR, before I re-enabled the PR check.

I think the way that poetry install is done in the workflow description and in the Tox environments seems wrong/duplicative. It ends up taking long as it's duplicated and you can see a mix of upgrades/downgrades done, that could be avoided.

[1] actions/runner-images#6216
[2] /Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found

@jesse-c jesse-c changed the title build: Lock GitHub runners OS' build: Lock GitHub runners' OS May 16, 2024
@jesse-c jesse-c self-assigned this May 17, 2024
@jesse-c jesse-c added the bug Something isn't working label May 17, 2024
@CLAassistant
Copy link

CLAassistant commented May 22, 2024

CLA assistant check
All committers have signed the CLA.

@jesse-c jesse-c force-pushed the lock-github-runners branch 5 times, most recently from a148fed to 08d9e7d Compare May 29, 2024 13:24
@jesse-c jesse-c marked this pull request as ready for review May 29, 2024 13:24
@sakoush sakoush self-requested a review May 29, 2024 13:42
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting it out! I left comments, once they are resolved then PR is good to go.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
@jesse-c jesse-c force-pushed the lock-github-runners branch 4 times, most recently from fa157f4 to 8565810 Compare May 30, 2024 12:30
@jesse-c
Copy link
Member Author

jesse-c commented May 30, 2024

Going to merge in, based on the latest results [1]. It looks like the new Docker setup still needs some work, based on the error message [2].

[1] https://github.com/SeldonIO/MLServer/actions/runs/9302553271?pr=1765
[2] https://github.com/SeldonIO/MLServer/actions/runs/9302553271/job/25602995328?pr=1765


self = <AsyncRetrying object at 0x122fad6c0 (stop=<tenacity.stop.stop_after_attempt object at 0x122fadbd0>, wait=<tenacity.wa...bject at 0x122fe9600>, before=<function before_nothing at 0x122fc9090>, after=<function after_nothing at 0x122fca7a0>)>
retry_state = <RetryCallState 4926532304: attempt #20; slept for 71.0; last result: failed (KafkaConnectionError KafkaConnectionError: Unable to bootstrap from [('localhost', 49621, <AddressFamily.AF_UNSPEC: 0>)])>

    def iter(self, retry_state: "RetryCallState") -> t.Union[DoAttempt, DoSleep, t.Any]:  # noqa
        fut = retry_state.outcome
        if fut is None:
            if self.before is not None:
                self.before(retry_state)
            return DoAttempt()
    
        is_explicit_retry = fut.failed and isinstance(fut.exception(), TryAgain)
        if not (is_explicit_retry or self.retry(retry_state)):
            return fut.result()
    
        if self.after is not None:
            self.after(retry_state)
    
        self.statistics["delay_since_first_attempt"] = retry_state.seconds_since_start
        if self.stop(retry_state):
            if self.retry_error_callback:
                return self.retry_error_callback(retry_state)
            retry_exc = self.retry_error_cls(fut)
            if self.reraise:
                raise retry_exc.reraise()
>           raise retry_exc from fut.exception()
E           tenacity.RetryError: RetryError[<Future at 0x125b33dc0 state=finished raised KafkaConnectionError>]

This was motivated by our macOS jobs failing [2] because
colima is missing. It looks like this is because the
latest versions of the macOS runner no longer have
colima installed by default [1].

colima is now explicitly installed.

[1] actions/runner-images#6216
[2] `/Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found`
@jesse-c jesse-c merged commit ab1f3f7 into SeldonIO:master May 30, 2024
25 of 26 checks passed
@jesse-c jesse-c deleted the lock-github-runners branch May 30, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants