Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colima #6216

Closed
1 of 2 tasks
mvgijssel opened this issue Sep 11, 2022 · 8 comments
Closed
1 of 2 tasks

Add colima #6216

mvgijssel opened this issue Sep 11, 2022 · 8 comments
Assignees
Labels
Area: Containers awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request OS: macOS

Comments

@mvgijssel
Copy link

Tool name

Colima

Tool license

MIT license

Add or update?

  • Add
  • Update

Desired version

0.4.4

Approximate size

17mb

Brief description of tool

Colima - container runtimes on macOS (and Linux) with minimal setup. Means you can run docker without having to install Docker for macOS and run into licensing issues (#2150).

URL for tool's homepage

https://github.com/abiosoft/colima

Provide a basic test case to validate the tool's functionality.

❯ colima version
colima version 0.4.4
git commit: 8bb1101a861a8b6d2ef6e16aca97a835f65c4f8f


### Platforms where you need the tool

- [ ] Azure DevOps
- [ ] GitHub Actions

### Virtual environments where you need the tool

- [ ] Ubuntu 18.04
- [ ] Ubuntu 20.04
- [ ] Ubuntu 22.04
- [X] macOS 10.15
- [X] macOS 11
- [X] macOS 12
- [ ] Windows Server 2019
- [ ] Windows Server 2022

### Can this tool be installed during the build?

```bash
brew install docker colima

Tool installation time in runtime

1 minute

Are you willing to submit a PR?

Sure!

@mikhailkoliada
Copy link
Contributor

@mvgijssel we will decide on adding it and get back to you.

@ddobranic
Copy link
Contributor

hi @mvgijssel! thank you for your proposal. we will add colima to our macOS images.

@mvgijssel
Copy link
Author

That’s awesome! Let me know if you need any help!

@ddobranic ddobranic added the awaiting-deployment Code complete; awaiting deployment and/or deployment in progress label Sep 27, 2022
@ddobranic
Copy link
Contributor

hello @mvgijssel! colima has been added to macOS images.

joffrey-bion added a commit to joffrey-bion/krossbow that referenced this issue Oct 12, 2022
Colima is now pre-installed on macOS runners, which provides
a container runtime and docker CLI can use without setting up
Docker Desktop and facing licensing issues:
actions/runner-images#6216 (comment)
joffrey-bion added a commit to joffrey-bion/krossbow that referenced this issue Oct 12, 2022
Colima is now pre-installed on macOS runners, which provides
a container runtime and docker CLI can use without setting up
Docker Desktop and facing licensing issues:
actions/runner-images#6216 (comment)
ghost pushed a commit to camunda/camunda that referenced this issue Nov 24, 2022
11040: ci(smoke-test): multi-arch container smoke test r=megglos a=megglos

## Description

Docker builds and smoke tests are only run on Linux machines as building docker containers on macOS and windows runners introduces complexity to the CI setup that we consider not worth the effort:
- macOS runners require the setup of [colima as a docker runtime](actions/runner-images#6216) which adds another 1.5-2m to the runtime
- on macOS testcontainers failed to detect the docker environment unless [additional environment variables](https://www.testcontainers.org/features/configuration/#customizing-docker-host-detection) have been set 
- some docker related actions are not supported on windows runners like [`docker/build-push-action`](docker/build-push-action#18 (comment))
- the docker setup on Githubs windows runners seems to be bound to the `windows/amd64` platform, see e.g. this [log](https://github.com/camunda/zeebe/actions/runs/3500015748/jobs/5862231609)

Usage of native arm64 runners is listed as a separate sub-task on #10986.


## Related issues

closes #11020



Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
Co-authored-by: Sebastian Bathke (Meggle) <sebastian.bathke@camunda.com>
@Jasperav
Copy link

@mvgijssel @ddobranic does any of you know why this is removed from macos 13?

@mvgijssel
Copy link
Author

No idea!

@ejsmith
Copy link
Contributor

ejsmith commented Jan 30, 2024

Yeah, wondering the same thing. Why was it removed?

@asottile-sentry
Copy link

it's also missing on the new macos-14 image as well

jesse-c pushed a commit to SeldonIO/MLServer that referenced this issue May 30, 2024
* build: Lock GitHub runners' OS

This was motivated by our macOS jobs failing [2] because
colima is missing. It looks like this is because the
latest versions of the macOS runner no longer have
colima installed by default [1].

colima is now explicitly installed.

[1] actions/runner-images#6216
[2] `/Users/runner/work/_temp/f19ffbff-27a9-4fc7-80b6-97791d2de141.sh: line 9: colima: command not found`

* build: Lock Colima

* build: Move macOS Docker installation to script

* build: Move macOS libomp activation to script

* build: Use latest Colima

The > 0.6.0 releases actually fix the issue we have linked [1][2][3].

[1] abiosoft/colima#577
[2] https://github.com/jesse-c/MLServer/blob/c3acd60995a72141027eff506e4fd330fe824179/hack/install-docker-macos.sh#L18-L20
[3] > Switch to new user-v2 network. Fixes abiosoft/colima#648, abiosoft/colima#603, abiosoft/colima#577, abiosoft/colima#779, abiosoft/colima#137, abiosoft/colima#740.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Containers awaiting-deployment Code complete; awaiting deployment and/or deployment in progress feature request OS: macOS
Projects
None yet
Development

No branches or pull requests

8 participants
@ejsmith @mvgijssel @Jasperav @mikhailkoliada @ddobranic @asottile-sentry @bogdan-damian-bgd and others