New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a conda install option for alibi
#579
Comments
Thanks for the effort! One thing I'm conscious of is the limited support of optional dependency semantics by @ascillitoe @mauicv keen to hear your thoughts. |
So it seems that |
Yes thank you for this @sugatoray! That's a good point re optional dependencies @jklaise. Just to check my understanding, with Not being able to group dependencies i.e. |
@ascillitoe on the first point, yes, that's my understanding of the feature. On the second point, definitely agree with explicit installation instructions as we modularise the package a bit more. Maybe it would be enough, but certainly not as automated as the The main think I'd like to avoid is maintenance overhead for |
Just to add a bit more food for thought here. I think when thinking about conda vs pip (not that we have to choose one), its important for us to keep in mind that the
Conda would hopefully improve things quite a bit here since the desired
(might have the channel syntax wrong here) |
Looking at the tests for @sugatoray's PR, it looks like the Windows platform one is currently failing due an issue with the I'm sure the above is fixable, but it does make me wonder if it's worth holding off on this exercise until we've completed the modularisation work and finalized our updated core vs optional dependencies. It depends on how much work it would be to update the conda recipe later, @sugatoray probably knows more wrt to that! |
Both recipes of alibi and alibi-detect are For instance, if you want to install it on Windows, the following should work. # first install pytorch from another channel
conda install -c pytorch pytorch
# then install alibi and alibi-detect
conda install -c conda-forge alibi alibi-detect This is happening because So, in a nutshell, this doesn't pose any challenges for the user. cc: @ascillitoe @jklaise |
Hi @sugatoray, that makes sense, thanks for the explanation. Thinking more about our dependencies I think we're fine to go ahead with this now, as can't actually see any major issues with our plans to change core vs optional dependencies in the future (and we can always deal with that later anyway). Just one thing, would it be possible to add a few of our dev team as Thanks again for your work on this, getting a conda recipe up and running will be a great help for our users 🙂 |
That's what I was about to suggest (to add one or more co-maintainers from here) 😊. I always prefer having devs/maintainers of the library itself, on the list of maintainers on the conda-forge recipe. This enables to release both PyPI and conda-forge more or less synchronously. Is there anyone you suggested, who has previous experience with conda-forge packaging or maintaining a package (feedstock) on conda-forge? If not, I can walk you through. It is fairly simple when it comes to maintenance. Typically, you only have to update a couple of fields in an yaml file (recipe: cc: @ascillitoe, @mauicv and @jklaise |
I don't believe any of us do actually, but keen to learn! I've had a brief look through the conda-forge docs and they look pretty comprehensive, but a walkthrough would be wonderful 😀. p.s. could we also add @arnaudvl to the list please? |
I have some knowledge as I actually attempted to make a |
Ah apologies @jklaise! |
@ascillitoe Sure. I don't have any reservations on adding maintainers. But, I would suggest to keep the number of conda-forge maintainers to a reasonable list of 2-4, who would actually be involved in keeping it updated. If anyone else is interested in updating the recipe, that's easy. All you need is a pull request to the feedstock with the intended changes. |
@sugatoray that makes sense, I would suggest myself and @ascillitoe then, thanks! |
cc: @jklaise @ascillitoe
|
❓ Command to check version and avilability of $ conda search -c conda-forge alibi
Loading channels: done
# Name Version Build Channel
alibi 0.6.3 pyhd8ed1ab_0 conda-forge |
@jklaise Please see this PR. I will push a similar PR for |
A conda installation option could be very helpful. I have already started working on this, to add
alibi
to conda-forge.Conda-forge PR:
alibi
andalibi-detect
from PyPI conda-forge/staged-recipes#17582Once the conda-forge PR is merged, you will be able to install the library with conda as follows:
💡 I will push a PR to update the docs once the package is available on conda-forge.
The text was updated successfully, but these errors were encountered: