Split Explainer into Base & Explainer #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 80.45% 80.46%
=======================================
Files 77 77
Lines 10634 10635 +1
=======================================
+ Hits 8556 8557 +1
Misses 2078 2078
|
jklaise
reviewed
May 4, 2022
alibi/api/interfaces.py
Outdated
| """ | ||
|
|
||
| meta: dict = attr.ib(default=attr.Factory(default_meta), repr=alibi_pformat) #: Explainer meta-data. |
There was a problem hiding this comment.
Explainer -> Object / Algorithm?
RobertSamoilescu
force-pushed
the
meta_interface
branch
from
6b7d006
to
4a7fda6
Compare
jklaise
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
Explainerclass into aBaseandExplainer.The
Baseclass currently implements a structured approach to handle metadata (to be extended). This split allows us to introduce other base classes for new packages that do not conform to theExplainerinterface. For example, algorithms for prototype selection are not explainers. Calling theexplainmethod when, in fact, they are summarizing/distilling the dataset is not appropriate. Furthermore, functionalities such as saving and loading might expect other arguments, and resetting the prediction might not apply.Possible to be used for the
confidencepackage too.Observation. The functionality of the
Explanationclass is already quite general and works for all packages. Changing the name to something more general would involve a lot of refactoring, which we don’t want to do, at least for now.