Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included 'start_label' for 'slic' segmentation. #753

Conversation

RobertSamoilescu
Copy link
Collaborator

The latest releases of skimage updated the slic default indexing to start from 1 instead of 0 for convention reasons. This conflicts with the alibi expectation which assumes that the indexing starts from 0.

This PR addresses this issue by forcing the slic segmentation indexing to start from 0 through the argument start_label=0. The default slic kwargs were updated with start_label=0 as well as the arguments in the example notebook. The docstring were updated as well to describe alibi expectation of the segmentation indexing. Those updates required a bump in the sklearn verison to a lower bound version of 0.17.2 (the stable version of 0.17.X).

Addresses issue #748

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #753 (61af313) into master (5f7b505) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   79.65%   79.63%   -0.02%     
==========================================
  Files         107      107              
  Lines       12657    12657              
==========================================
- Hits        10082    10080       -2     
- Misses       2575     2577       +2     
Impacted Files Coverage Δ
alibi/explainers/anchors/anchor_image.py 93.12% <ø> (ø)
alibi/explainers/ale.py 65.21% <0.00%> (-0.44%) ⬇️
alibi/explainers/partial_dependence.py 45.67% <0.00%> (-0.21%) ⬇️

Copy link
Member

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jklaise jklaise merged commit ff7fcbd into SeldonIO:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants