Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate ray installation during Python 3.10 CI #756

Merged
merged 1 commit into from Sep 13, 2022

Conversation

ascillitoe
Copy link
Contributor

Ray now supports Python 3.10, so adding it back into the Python 3.10 CI.

Also note that any tests requiring ray were not running at all due to an issue with the syntax of this version check in the github action yaml files (see SeldonIO/alibi-detect#615). This should now be fixed since the version does not need to be checked.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #756 (6afd434) into master (c3a8da2) will increase coverage by 2.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   79.64%   82.45%   +2.80%     
==========================================
  Files         107      107              
  Lines       12658    12658              
==========================================
+ Hits        10082    10437     +355     
+ Misses       2576     2221     -355     
Impacted Files Coverage Δ
alibi/explainers/shap_wrappers.py 92.29% <0.00%> (+0.39%) ⬆️
alibi/explainers/tests/test_shap_wrappers.py 97.40% <0.00%> (+1.68%) ⬆️
...i/explainers/anchors/anchor_tabular_distributed.py 27.18% <0.00%> (+23.30%) ⬆️
alibi/utils/distributed.py 65.38% <0.00%> (+62.01%) ⬆️
alibi/utils/tests/test_distributed.py 94.60% <0.00%> (+90.68%) ⬆️

Copy link
Member

@jklaise jklaise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascillitoe ascillitoe merged commit 402b8e6 into SeldonIO:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants