Merge pull request #537 from hmonteiro/fix_module_based_serving

Allow fully qualified class name to be used for the model serving image.
SeldonIO · May 4, 2019 · 67b29d7 · 67b29d7
2 parents ddc2d90 + 1fac118
commit 67b29d7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 2 deletions.
diff --git a/python/seldon_core/microservice.py b/python/seldon_core/microservice.py
@@ -191,7 +191,7 @@ def main():
         user_class = getattr(interface_file, args.interface_name)
     else:
         logger.info("Importing submodule %s",parts)
-        interface_file = importlib.import_module(args.interface_name)
+        interface_file = importlib.import_module(parts[0])
         user_class = getattr(interface_file, parts[1])
 
     if args.persistence:

diff --git a/python/tests/model-template-app2/.s2i/environment b/python/tests/model-template-app2/.s2i/environment
@@ -1,4 +1,4 @@
-MODEL_NAME=mymodule.MyModel
+MODEL_NAME=mymodule.my_model.MyModel
 API_TYPE=REST
 SERVICE_TYPE=MODEL
 PERSISTENCE=0
diff --git a/...s/model-template-app2/mymodule/MyModel.py → .../model-template-app2/mymodule/my_model.py b/...s/model-template-app2/mymodule/MyModel.py → .../model-template-app2/mymodule/my_model.py