Allow fully qualified class name to be used for the model serving image. #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
pushed a commit
that referenced
this pull request
Dec 2, 2022
* small fixes for mlserver, docs and envoy yaml * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where the
MODEL_NAMEvariable was not expected to be the fully qualified name of the model serving class. If aMODEL_NAMEwas supplied asmymodule.MyModel, the microservice code was actually trying to loadmymodule.MyModel.MyModel.This change makes it so that you can just supply the fully qualified class name, allowing the use of standard snake case file names, e.g.
mymodule.my_model.MyModelThis fixes issue #533