Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to update integration test script with helm 3.0 version #1138

Closed
lennon310 opened this issue Nov 25, 2019 · 2 comments
Closed

Need to update integration test script with helm 3.0 version #1138

lennon310 opened this issue Nov 25, 2019 · 2 comments
Assignees
@glindsell
Projects
1.0
Milestone
1.0

Comments

@lennon310
Copy link
Contributor

lennon310 commented Nov 25, 2019 •
edited

This line is having error because in helm 3.0 the tiller is removed. So install_helm here in the script needs update.

helm init --service-account tiller
Error: unknown flag: --service-account
@axsaucedo axsaucedo added this to To do in 1.0 via automation Nov 27, 2019
@axsaucedo axsaucedo added this to the 1.0 milestone Nov 27, 2019
@axsaucedo
Copy link
Contributor

Adding to 1.0

This was referenced Nov 28, 2019
Closed
Closed
glindsell pushed a commit to glindsell/seldon-core that referenced this issue Dec 3, 2019
SeldonIO#1138 update integration test script with helm 3.0
33a8344 
Signed-off-by: glindsell <gl@seldon.io>
@glindsell glindsell mentioned this issue Dec 3, 2019
Merged
@ukclivecox ukclivecox moved this from To do to In progress in 1.0 Dec 5, 2019
@glindsell
Copy link
Contributor

Fixed #1186

1.0 automation moved this from In progress to Done Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glindsell glindsell

Labels
None yet
Projects
No open projects
1.0
  
Done
Milestone
1.0
Development

No branches or pull requests
4 participants
@axsaucedo @lennon310 @glindsell @ryandawsonuk