#1138 update integration test script with helm 3.0 #1181
Conversation
Signed-off-by: glindsell <gl@seldon.io>
glindsell
requested review from
axsaucedo,
gsunner,
ukclivecox and
ryandawsonuk
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test integration |
|
@glindsell: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| @@ -18,14 +18,10 @@ kind_build_operator: | |||
|
|
|||
| kind_build_images: kind_build_engine kind_build_operator | |||
|
|
|||
| install_helm: | |||
There was a problem hiding this comment.
Installation tests fail as install_helm command is required, so either script needs to be modified or install_helm should be added
| install_ambassador: | ||
| helm install stable/ambassador -f ambassador_values.yaml --name ambassador --set crds.keep=false --namespace seldon --set replicaCount=1 | ||
| helm repo add stable https://kubernetes-charts.storage.googleapis.com/ |
There was a problem hiding this comment.
I do think the helm set up should be separate, as helm is used in other parts of the integration tests.
| helm install stable/ambassador -f ambassador_values.yaml --name ambassador --set crds.keep=false --namespace seldon --set replicaCount=1 | ||
| helm repo add stable https://kubernetes-charts.storage.googleapis.com/ | ||
| helm repo update | ||
| helm install ambassador stable/ambassador -f ambassador_values.yaml --set crds.keep=false --namespace seldon --set replicaCount=1 |
There was a problem hiding this comment.
Right now the end to end tests use the dependencies in the core-builder image, which I believe don't use helm 3.x, so this change would not only have to be done in the core-builder image, and you would have to change the image that it points towards
|
Please see #1186 |
#1138
Signed-off-by: glindsell gl@seldon.io