allow extra custom field in model metadata #2376

RafalSkolasinski · 2020-09-03T14:34:28Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Extend model metadata schema to allow custom `custom`. The new field is a mapping: string -> string and can be used to store arbitrary information as part of model metadata.,

RafalSkolasinski · 2020-09-03T14:34:48Z

/test integration

seldondev · 2020-09-03T14:36:04Z

Thu Sep 3 14:36:03 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=1

seldondev · 2020-09-03T14:36:06Z

Thu Sep 3 14:36:05 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=2

seldondev · 2020-09-03T14:36:13Z

Thu Sep 3 14:36:12 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=3

seldondev · 2020-09-03T15:23:32Z

Thu Sep 3 15:23:26 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=5

seldondev · 2020-09-03T15:23:36Z

Thu Sep 3 15:23:35 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=4

seldondev · 2020-09-08T16:43:07Z

Tue Sep 8 16:43:00 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=6

seldondev · 2020-09-08T16:43:14Z

Tue Sep 8 16:43:13 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=7

seldondev · 2020-09-08T16:43:17Z

Tue Sep 8 16:43:16 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=9

seldondev · 2020-09-08T16:43:17Z

Tue Sep 8 16:43:16 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=8

RafalSkolasinski · 2020-09-08T16:43:30Z

/test integration

seldondev · 2020-09-08T16:45:59Z

Tue Sep 8 16:45:57 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=10

seldondev · 2020-09-08T16:47:01Z

Tue Sep 8 16:47:00 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=11

seldondev · 2020-09-08T16:47:02Z

Tue Sep 8 16:47:00 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=12

RafalSkolasinski · 2020-09-08T17:09:51Z

/test integration

seldondev · 2020-09-08T17:11:14Z

Tue Sep 8 17:11:13 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=13

seldondev · 2020-09-08T17:11:25Z

Tue Sep 8 17:11:24 UTC 2020
The logs for [integration] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=15

seldondev · 2020-09-08T17:11:26Z

Tue Sep 8 17:11:25 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=14

axsaucedo

Looks good! I added a couple of questions. Other than that it seems the metadata integration tests are failing

python/seldon_core/metadata.py

doc/source/python/api/seldon_core.proto.rst

seldondev · 2020-09-16T08:29:59Z

Wed Sep 16 08:29:58 UTC 2020
The logs for [notebooks] [38] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/38.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=38

RafalSkolasinski · 2020-09-16T13:14:58Z

/retest

seldondev · 2020-09-16T13:16:36Z

Wed Sep 16 13:16:31 UTC 2020
The logs for [integration] [40] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/40.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=40

RafalSkolasinski · 2020-09-17T09:07:41Z

/retest

seldondev · 2020-09-17T09:09:39Z

Thu Sep 17 09:09:35 UTC 2020
The logs for [integration] [41] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/41.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=41

RafalSkolasinski · 2020-09-17T14:06:27Z

rebased onto master, retriggering tests
/test integration
/test notebooks

seldondev · 2020-09-17T14:08:14Z

Thu Sep 17 14:08:13 UTC 2020
The logs for [lint] [43] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/43.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=43

seldondev · 2020-09-17T14:08:16Z

Thu Sep 17 14:08:15 UTC 2020
The logs for [pr-build] [42] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/42.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=42

seldondev · 2020-09-17T14:08:17Z

Thu Sep 17 14:08:16 UTC 2020
The logs for [integration] [45] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/45.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=45

seldondev · 2020-09-17T14:08:31Z

Thu Sep 17 14:08:30 UTC 2020
The logs for [notebooks] [44] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/44.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=44

RafalSkolasinski · 2020-09-18T13:37:16Z

Failing notebook tests will be fixed by #2453 as these are exactly two tests failing in #2454.

~~@axsaucedo Shall we force merge it then?~~

Actually better not as I am modifying same notebook here. Will most likely have to rebase and fix conflict.

RafalSkolasinski · 2020-09-21T13:51:36Z

/test integration
/test notebooks

seldondev · 2020-09-21T13:53:10Z

Mon Sep 21 13:53:07 UTC 2020
The logs for [pr-build] [46] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/46.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=46

seldondev · 2020-09-21T13:53:10Z

Mon Sep 21 13:53:06 UTC 2020
The logs for [notebooks] [48] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/48.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=48

seldondev · 2020-09-21T13:53:12Z

Mon Sep 21 13:53:11 UTC 2020
The logs for [lint] [47] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/47.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=47

seldondev · 2020-09-21T13:53:29Z

Mon Sep 21 13:53:29 UTC 2020
The logs for [integration] [49] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/49.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=49

RafalSkolasinski · 2020-09-21T16:05:49Z

/test notebooks

seldondev · 2020-09-21T16:07:33Z

Mon Sep 21 16:07:29 UTC 2020
The logs for [notebooks] [50] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2376/50.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2376 --build=50

seldondev added the size/S label Sep 3, 2020

RafalSkolasinski marked this pull request as draft September 3, 2020 14:34

seldondev added size/XXL and removed size/S labels Sep 3, 2020

RafalSkolasinski force-pushed the issues/2312/metadata-custom-tags branch from 4e08ce1 to 1e49902 Compare September 8, 2020 16:41

RafalSkolasinski changed the title ~~allow extra tags in model metadata~~ allow extra custom field in model metadata Sep 8, 2020

seldondev added the do-not-merge/work-in-progress label Sep 8, 2020

RafalSkolasinski marked this pull request as ready for review September 8, 2020 16:43

seldondev removed the do-not-merge/work-in-progress label Sep 8, 2020

RafalSkolasinski requested a review from axsaucedo September 8, 2020 16:43

RafalSkolasinski force-pushed the issues/2312/metadata-custom-tags branch from 1e49902 to 6490c5f Compare September 8, 2020 16:44

axsaucedo suggested changes Sep 8, 2020

View reviewed changes

python/seldon_core/metadata.py Show resolved Hide resolved

doc/source/python/api/seldon_core.proto.rst Outdated Show resolved Hide resolved

RafalSkolasinski force-pushed the issues/2312/metadata-custom-tags branch from cdcc9ac to d7b24ef Compare September 17, 2020 14:06

RafalSkolasinski added 9 commits September 21, 2020 14:50

allow extra tags in model metadata

a6894e7

fix tests and generate protos

ec8caf0

update executor protos to include new metadata field

fd5c363

metadata extension: rename tags fields to custom

b128cb8

add examples

9b6e405

fix unit test

64f190f

fix accidental commit of whitespaces change in two rst files

9e2466a

adjust integration tests

de403ed

adjust integration tests #2

3382606

RafalSkolasinski force-pushed the issues/2312/metadata-custom-tags branch from d7b24ef to 3382606 Compare September 21, 2020 13:51

axsaucedo merged commit 00f2d30 into SeldonIO:master Sep 21, 2020

allow extra custom field in model metadata #2376

allow extra custom field in model metadata #2376

Conversation

RafalSkolasinski commented Sep 3, 2020 • edited

RafalSkolasinski commented Sep 3, 2020

seldondev commented Sep 3, 2020

seldondev commented Sep 3, 2020

seldondev commented Sep 3, 2020

seldondev commented Sep 3, 2020

seldondev commented Sep 3, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

RafalSkolasinski commented Sep 8, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

RafalSkolasinski commented Sep 8, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

seldondev commented Sep 8, 2020

axsaucedo left a comment

Choose a reason for hiding this comment

seldondev commented Sep 16, 2020

RafalSkolasinski commented Sep 16, 2020

seldondev commented Sep 16, 2020

RafalSkolasinski commented Sep 17, 2020

seldondev commented Sep 17, 2020

RafalSkolasinski commented Sep 17, 2020

seldondev commented Sep 17, 2020

seldondev commented Sep 17, 2020

seldondev commented Sep 17, 2020

seldondev commented Sep 17, 2020

RafalSkolasinski commented Sep 18, 2020 • edited

RafalSkolasinski commented Sep 21, 2020

seldondev commented Sep 21, 2020

seldondev commented Sep 21, 2020

seldondev commented Sep 21, 2020

seldondev commented Sep 21, 2020

RafalSkolasinski commented Sep 21, 2020

seldondev commented Sep 21, 2020

RafalSkolasinski commented Sep 3, 2020 •

edited

RafalSkolasinski commented Sep 18, 2020 •

edited