Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow annotations on Service created by operator #2590

Closed
groszewn opened this issue Nov 1, 2020 · 2 comments · Fixed by #2618
Closed

Allow annotations on Service created by operator #2590

groszewn opened this issue Nov 1, 2020 · 2 comments · Fixed by #2618
Assignees
@groszewn
Projects
1.6.0
Milestone
1.6

Comments

@groszewn
Copy link
Contributor

groszewn commented Nov 1, 2020

Certain integrations expect annotations placed on the service resource in order to work. One, in particular, is the datadog healthcheck configuration which can seen here.

Similarly to how the predictorSpec annotations can be used to provide a custom service name, I'm thinking that we can have the predictorSpec annotations be applied to the corresponding created service as well. It seems like these annotations would need to be added here for the predictor service and here (if needed) for the container service.
@groszewn groszewn added the triage Needs to be triaged and prioritised accordingly label Nov 1, 2020
@ukclivecox
Copy link
Contributor

Sounds good. Would you suggest a CRD addition?

@groszewn
Copy link
Contributor Author

groszewn commented Nov 2, 2020

Definitely open to suggestions here. It seems like the PredictorSpec annotations could be reused and just applied to the created service.

@ukclivecox ukclivecox added this to the 1.5 milestone Nov 5, 2020
@ukclivecox ukclivecox added this to To do in 1.5 via automation Nov 5, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Nov 5, 2020
groszewn added a commit to groszewn/seldon-core that referenced this issue Nov 6, 2020
@groszewn
feat(svc): Add predictorSpec annotations to service
587a556 
Capture predictorSpec annotations and apply them to the created
services.

Contributes to SeldonIO#2590

Signed-off-by: Nick Groszewski <groszewn@gmail.com>
groszewn added a commit to groszewn/seldon-core that referenced this issue Nov 6, 2020
@groszewn
feat(svc): Add predictorSpec annotations to service
c134881 
Capture predictorSpec annotations and apply them to the created
services.

Contributes to SeldonIO#2590

Signed-off-by: Nick Groszewski <groszewn@gmail.com>
@groszewn groszewn mentioned this issue Nov 6, 2020
Merged
groszewn added a commit to groszewn/seldon-core that referenced this issue Nov 15, 2020
@groszewn
feat(svc): Add predictorSpec annotations to service
d5b44c1 
Capture predictorSpec annotations and apply them to the created
services.

Contributes to SeldonIO#2590

Signed-off-by: Nick Groszewski <groszewn@gmail.com>
groszewn added a commit to groszewn/seldon-core that referenced this issue Nov 16, 2020
@groszewn
feat(svc): Add predictorSpec annotations to service
f0494f0 
Capture predictorSpec annotations and apply them to the created
services.

Contributes to SeldonIO#2590

Signed-off-by: Nick Groszewski <groszewn@gmail.com>
groszewn added a commit to groszewn/seldon-core that referenced this issue Nov 24, 2020
@groszewn
feat(svc): Add predictorSpec annotations to service
5081a77 
Capture predictorSpec annotations and apply them to the created
services.

Contributes to SeldonIO#2590

Signed-off-by: Nick Groszewski <groszewn@gmail.com>
@ukclivecox ukclivecox modified the milestones: 1.5, 1.6 Nov 30, 2020
@ukclivecox ukclivecox added this to To do in 1.6.0 via automation Nov 30, 2020
@ukclivecox ukclivecox removed this from To do in 1.5 Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@groszewn groszewn

Labels
None yet
Projects
No open projects
1.6.0
To do
Milestone
1.6
Development

Successfully merging a pull request may close this issue.

feat(svc): Add predictorSpec annotations to service groszewn/seldon-core
2 participants
@ukclivecox @groszewn