Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(svc): Add predictorSpec annotations to service #2618

Merged
merged 1 commit into from
Feb 25, 2021
Merged

feat(svc): Add predictorSpec annotations to service #2618

merged 1 commit into from
Feb 25, 2021

Conversation

groszewn
Copy link
Contributor

@groszewn groszewn commented Nov 6, 2020

What this PR does / why we need it:

In order to leverage integrations that expect annotations on resources with constant IPs (e.g. services), there needs to be a way to specify annotations to be applied.

Which issue(s) this PR fixes:

Fixes #2590

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Apply predictorSpec annotations to created services

@seldondev
Copy link
Collaborator

Hi @groszewn. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign axsaucedo
You can assign the PR to them by writing /assign @axsaucedo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@groszewn
Copy link
Contributor Author

groszewn commented Nov 6, 2020

/assign @axsaucedo

@groszewn
Copy link
Contributor Author

/assign @cliveseldon

@axsaucedo
Copy link
Contributor

Thanks @groszewn ! Looks great
/ok-to-test
/test integration

@seldondev
Copy link
Collaborator

Thu Nov 12 10:19:53 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=1

@seldondev
Copy link
Collaborator

Thu Nov 12 10:20:37 UTC 2020
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=2

@seldondev
Copy link
Collaborator

Thu Nov 12 10:22:52 UTC 2020
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=3

@seldondev
Copy link
Collaborator

Sun Nov 15 16:29:57 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=4

@seldondev
Copy link
Collaborator

Sun Nov 15 16:29:59 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=5

@groszewn
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sun Nov 15 16:48:27 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=6

@seldondev
Copy link
Collaborator

Mon Nov 16 16:26:30 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=7

@seldondev
Copy link
Collaborator

Mon Nov 16 16:26:35 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=8

@groszewn
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Nov 16 16:38:58 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=9

@groszewn
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Mon Nov 16 17:22:40 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=10

@groszewn
Copy link
Contributor Author

/retest

@seldondev
Copy link
Collaborator

Mon Nov 16 18:12:18 UTC 2020
The logs for [integration] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=11

@groszewn
feat(svc): Add predictorSpec annotations to service
5081a77 
Capture predictorSpec annotations and apply them to the created
services.

Contributes to SeldonIO#2590

Signed-off-by: Nick Groszewski <groszewn@gmail.com>
@seldondev
Copy link
Collaborator

Tue Nov 24 02:05:25 UTC 2020
The logs for [lint] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=13

@seldondev
Copy link
Collaborator

Tue Nov 24 02:07:25 UTC 2020
The logs for [pr-build] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=12

@groszewn
Copy link
Contributor Author

/test lint

@seldondev
Copy link
Collaborator

Tue Nov 24 02:36:30 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=14

@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Thu Dec 10 10:59:55 UTC 2020
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=16

@seldondev
Copy link
Collaborator

Thu Dec 10 10:59:55 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=15

@seldondev
Copy link
Collaborator

Thu Dec 10 10:59:57 UTC 2020
The logs for [integration] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2618/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2618 --build=17

@ukclivecox
Copy link
Contributor

/test integration

@ukclivecox ukclivecox merged commit dcabfa3 into SeldonIO:master Feb 25, 2021
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 5081a77
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 5081a77
  • failed to process repo SeldonIO/seldon-core refref 5081a77
  • failed to list files in directory /var/tmp/gitrepo799923688/.lighthouse
  • open /var/tmp/gitrepo799923688/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

Assignees

@axsaucedo axsaucedo

@ukclivecox ukclivecox

Labels
ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow annotations on Service created by operator
4 participants
@groszewn @seldondev @axsaucedo @ukclivecox