Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC Operator continues to reconcile objects that are being (foreground) delete #2781

Closed
RafalSkolasinski opened this issue Dec 14, 2020 · 0 comments · Fixed by #2782
Closed

SC Operator continues to reconcile objects that are being (foreground) delete #2781

RafalSkolasinski opened this issue Dec 14, 2020 · 0 comments · Fixed by #2782
Assignees
@RafalSkolasinski
Labels
bug triage Needs to be triaged and prioritised accordingly
Milestone
1.6

Comments

@RafalSkolasinski
Copy link
Contributor

RafalSkolasinski commented Dec 14, 2020 •
edited
Loading

When SeldonDeployment is removed the dependents can be garbage collected in two ways: foreground and background.

ArgoCD does foreground deletion, see comment, while kubectl does background.

Describe the bug

When ArgoCD does foreground deletion, the SC Operator keep recreating the dependent resources.

To reproduce

Details provided in argoproj/argo-cd#5040

Expected behaviour

Deletion happens without issues.
@RafalSkolasinski RafalSkolasinski added bug triage Needs to be triaged and prioritised accordingly labels Dec 14, 2020
@RafalSkolasinski RafalSkolasinski self-assigned this Dec 14, 2020
@RafalSkolasinski RafalSkolasinski added this to the 1.6 milestone Dec 14, 2020
@RafalSkolasinski RafalSkolasinski mentioned this issue Dec 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafalSkolasinski RafalSkolasinski

Labels
bug triage Needs to be triaged and prioritised accordingly
Projects
None yet
Milestone
1.6
Development

Successfully merging a pull request may close this issue.

do not act on resources that have deletion timestamp set
1 participant
@RafalSkolasinski