do not act on resources that have deletion timestamp set

[RafalSkolasinski]

What this PR does / why we need it:

This avoids having Operator re-creating Pods (and other resources) that are being removed through foreground deletion mechanism, e.g. ArgoCD-powered gitops.

Which issue(s) this PR fixes:

Closes #2781

Special notes for your reviewer:

For reference, this is how it is done in kfserving.

This is important because in foreground deletion resource is still available through the API while it is being deleted.
If we don't stop early on the reconcile logic we would be recreating the pods that are being deleted.

Logic here differs from one in kfserving as we do not use finalizers.

Does this PR introduce a user-facing change?:

None

[seldondev]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Mon Dec 14 17:05:47 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=2

[seldondev]

Mon Dec 14 17:06:00 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=1

[RafalSkolasinski]

/test this

[RafalSkolasinski]

/test integration

[seldondev]

Mon Dec 14 17:09:46 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=4

[seldondev]

Mon Dec 14 17:09:54 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=3

[seldondev]

Mon Dec 14 18:14:34 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=6

[seldondev]

Mon Dec 14 18:14:44 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=5

[RafalSkolasinski]

/test integration
/test notebook

[RafalSkolasinski]

/test notebooks

[seldondev]

Tue Dec 15 10:43:12 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=7

[seldondev]

Tue Dec 15 10:44:46 UTC 2020
The logs for [notebooks] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=8

[RafalSkolasinski]

/test notebooks

[seldondev]

Tue Dec 15 14:43:13 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=9

[seldondev]

Tue Dec 15 14:43:30 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=10

[seldondev]

Tue Dec 15 14:43:58 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=11

[seldondev]

Tue Dec 15 14:44:13 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=12

[seldondev]

Tue Dec 15 14:44:32 UTC 2020
The logs for [notebooks] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=13

[seldondev]

Tue Dec 15 18:24:46 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=14

[seldondev]

Tue Dec 15 18:24:53 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=15

[seldondev]

Tue Dec 15 18:40:42 UTC 2020
The logs for [pr-build] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=16

[seldondev]

Tue Dec 15 18:40:54 UTC 2020
The logs for [lint] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=17

[axsaucedo]

/test notebooks

[axsaucedo]

/test integration

[axsaucedo]

Meant to trigger integration (stopped the notebooks pipeline)

[seldondev]

Tue Dec 15 19:40:42 UTC 2020
The logs for [integration] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=19

[seldondev]

@RafalSkolasinski: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
notebooks	f77fb1c	link	/test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[axsaucedo]

/test integration

[seldondev]

Wed Dec 16 08:36:27 UTC 2020
The logs for [integration] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=20

[seldondev]

Wed Dec 16 09:58:02 UTC 2020
The logs for [lint] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=22

[seldondev]

Wed Dec 16 09:58:07 UTC 2020
The logs for [pr-build] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2782/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2782 --build=21