Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for custom metrics in feedback #1366

Merged
merged 1 commit into from
Jan 27, 2020
Merged

add example for custom metrics in feedback #1366

merged 1 commit into from
Jan 27, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

This adds example related to issue #315

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Fri Jan 24 14:33:40 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1366/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1366 --build=2

@seldondev
Copy link
Collaborator

Fri Jan 24 14:33:53 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1366/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1366 --build=1

Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just make sure to add the nblink and jupyter reference in the docs.

@adriangonz
Copy link
Contributor

/approve

@axsaucedo that should be already there in https://docs.seldon.io/projects/seldon-core/en/latest/examples/tmpl_model_with_metrics.html

From my side the only change would be to move it to Kind, but I realise that's outside the scope of this issue and should be tackled as part of #1256 instead.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev added the lgtm label Jan 27, 2020
@seldondev
Copy link
Collaborator

Mon Jan 27 14:16:13 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1366/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1366 --build=3

@seldondev
Copy link
Collaborator

Mon Jan 27 14:16:26 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1366/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1366 --build=4

@seldondev seldondev merged commit f3343e3 into SeldonIO:master Jan 27, 2020
@RafalSkolasinski RafalSkolasinski deleted the issue/315 branch January 27, 2020 14:42
@axsaucedo axsaucedo removed their assignment May 13, 2021
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 519cc3b
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 519cc3b
  • failed to process repo SeldonIO/seldon-core refref 519cc3b
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants