Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XGBoost #1483

Merged
merged 9 commits into from
Mar 9, 2020
Merged

Update XGBoost #1483

merged 9 commits into from
Mar 9, 2020

Conversation

adriangonz
Copy link
Contributor

Fixes #1394

Changelog

  • Update xgboost to 1.0.1 on XGBOOST_SERVER
  • Build and push 0.3-SNAPSHOT versions of XGBOOST_SERVER (and MLFLOW_SERVER)
  • Use 0.3-SNAPSHOT on seldon-config values so that they get tested during integration

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@seldondev
Copy link
Collaborator

Wed Feb 26 09:32:59 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=1

@seldondev
Copy link
Collaborator

Wed Feb 26 09:33:03 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=2

@adriangonz
Copy link
Contributor Author

/cc @gsunner @RafalSkolasinski
/test integration

@gsunner I've built a new 0.3-SNAPSHOT version for the MLFLOW_SERVER (which was still on 0.2) and XGBOOST_SERVER (including these changes). Are these taken into account as part of the release process? (i.e. will they get promoted to 0.3 and the version changed to 0.4-SNAPSHOT?)

@seldondev
Copy link
Collaborator

Wed Feb 26 09:35:35 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=3

@adriangonz
Copy link
Contributor Author

We can use 0.3 directly on the pre-packaged servers.

@axsaucedo axsaucedo changed the title Update XGBoost WIP: Update XGBoost Mar 2, 2020
@adriangonz
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Mon Mar 2 13:47:19 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=5

@seldondev
Copy link
Collaborator

Mon Mar 2 13:47:32 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=6

@seldondev
Copy link
Collaborator

Mon Mar 2 13:48:59 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=4

@adriangonz adriangonz changed the title WIP: Update XGBoost Update XGBoost Mar 3, 2020
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafalSkolasinski
Copy link
Contributor

/lgtm
/approve

@adriangonz
Copy link
Contributor Author

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz, RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Mon Mar 9 14:37:20 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=7

@seldondev
Copy link
Collaborator

Mon Mar 9 14:37:24 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1483/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1483 --build=8

@seldondev seldondev merged commit eb4ef8a into SeldonIO:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Xgboost 0.9
3 participants