Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swagger UI with Embedded Seldon Deployment Values #1744

Merged
merged 18 commits into from May 1, 2020

Conversation

axsaucedo
Copy link
Contributor

PR includes:

  • Logic to embed SeldonDeployment variables into OpenAPI file
  • Integration tests to ensure the openAPI schema endpoints work
  • Documentation with images to show users how they can use it
  • Unit tests in executor to ensure logic works with the assumptions made explicit
  • Updates on Swagger UI configuration (hide configfile bar)

image

@seldondev
Copy link
Collaborator

Sun Apr 26 14:54:36 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=1

@seldondev
Copy link
Collaborator

Sun Apr 26 14:54:41 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=2

@axsaucedo
Copy link
Contributor Author

Hmm strange, it seems the test failure is on test_model_template_app_grpc_metrics python. Will try to re-run to see if it's sporadic, but I remember there was an issue with the GRPC library, perhaps it could be related (as thre are no changes related to GRPC in this PR).

/test all

@seldondev
Copy link
Collaborator

Sun Apr 26 15:44:32 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=5

@seldondev
Copy link
Collaborator

Sun Apr 26 15:44:37 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=3

@seldondev
Copy link
Collaborator

Sun Apr 26 15:44:39 UTC 2020
The logs for [notebooks] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=4

@seldondev
Copy link
Collaborator

Sun Apr 26 15:44:49 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=6

@axsaucedo
Copy link
Contributor Author

/test notebooks

@seldondev
Copy link
Collaborator

Sun Apr 26 17:45:12 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=7

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I've added a couple comments below, but I think this looks great!

executor/api/rest/utils.go Show resolved Hide resolved
executor/Makefile Show resolved Hide resolved
executor/api/rest/utils.go Show resolved Hide resolved
@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Apr 30 09:52:46 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=9

@seldondev
Copy link
Collaborator

Thu Apr 30 09:52:51 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=8

@seldondev
Copy link
Collaborator

seldondev commented Apr 30, 2020

@axsaucedo: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
notebooks 62379d8 link /test notebooks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@axsaucedo
Copy link
Contributor Author

Failed test is test_model_template_app_grpc_metrics which is related to flaky test in #1745
/test this

@seldondev
Copy link
Collaborator

Thu Apr 30 10:21:40 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=10

@seldondev
Copy link
Collaborator

Thu Apr 30 19:28:43 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=13

@seldondev
Copy link
Collaborator

Thu Apr 30 19:28:52 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1744/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1744 --build=14

@axsaucedo axsaucedo merged commit 89f37a6 into SeldonIO:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants