Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add managed-by label #1937

Merged
merged 3 commits into from Jun 16, 2020
Merged

Conversation

ryandawsonuk
Copy link
Contributor

fixes #1936

@ryandawsonuk
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Jun 11 16:22:17 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=3

@seldondev
Copy link
Collaborator

Thu Jun 11 16:28:50 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=1

@seldondev
Copy link
Collaborator

Thu Jun 11 16:28:52 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=2

@seldondev
Copy link
Collaborator

Mon Jun 15 08:37:49 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=5

@seldondev
Copy link
Collaborator

Mon Jun 15 08:37:52 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=4

@ryandawsonuk ryandawsonuk changed the title add managed-by label WIP: add managed-by label Jun 15, 2020
@ryandawsonuk
Copy link
Contributor Author

ryandawsonuk commented Jun 15, 2020

When testing in KIND I'm finding that the label is not currently getting onto the Pod. It does get onto the service (the one on port 9000).

I'm attempting to piggy-back on the labels for component type such as 'model' or 'router'. Those labels are likewise only appearing on the services and not pods.

@ryandawsonuk
Copy link
Contributor Author

Oh the label is on the Deployment and just not on the Pod. Will try moving it into the spec section.

@seldondev
Copy link
Collaborator

Mon Jun 15 09:23:49 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=7

@seldondev
Copy link
Collaborator

Mon Jun 15 09:25:13 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=6

@ryandawsonuk ryandawsonuk changed the title WIP: add managed-by label add managed-by label Jun 15, 2020
@ryandawsonuk
Copy link
Contributor Author

It is coming through now. And services are still correctly matching to deployments as I'm able to make requests and get responses.

@seldondev seldondev added size/S and removed size/XS labels Jun 16, 2020
@seldondev
Copy link
Collaborator

Tue Jun 16 12:47:48 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=9

@seldondev
Copy link
Collaborator

Tue Jun 16 12:47:50 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=8

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jun 16 18:36:16 UTC 2020
The logs for [lint] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=11

@seldondev
Copy link
Collaborator

Tue Jun 16 18:36:24 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1937/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1937 --build=10

@seldondev seldondev merged commit fde94ab into SeldonIO:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add managed-by label
3 participants