Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go dependencies: zap istio knative #2129

Merged
merged 4 commits into from Jul 14, 2020

Conversation

RafalSkolasinski
Copy link
Member

@RafalSkolasinski RafalSkolasinski commented Jul 14, 2020

Closes #2128 (knative.dev)
Closes #2127 (zap)
Closes #2126 (istio.io)

Knative dev go.mod updated entry generated with

go get knative.dev/pkg@release-0.14

Replaces #2125 (istio.io)
Updated entry for go.mod generated with

go get istio.io/api@release-1.5
go get istio.io/client-go@release-1.5

Replaces #2122

Achieved through by running
	go get istio.io/api@release-1.5
	go get istio.io/client-go@release-1.5
Done with: go get -u knative.dev/pkg@release-0.14
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rafalskolasinski
You can assign the PR to them by writing /assign @rafalskolasinski in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Jul 14 14:58:40 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2129/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2129 --build=1

@seldondev
Copy link
Collaborator

Tue Jul 14 14:59:18 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2129/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2129 --build=2

@RafalSkolasinski
Copy link
Member Author

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Tue Jul 14 15:18:18 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2129/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2129 --build=3

@seldondev
Copy link
Collaborator

Tue Jul 14 15:18:31 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2129/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2129 --build=4

@RafalSkolasinski
Copy link
Member Author

Integration fail on TestLocalOperators.test_labelled_operator - starting again.

@RafalSkolasinski
Copy link
Member Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jul 14 17:00:43 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2129/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2129 --build=5

@RafalSkolasinski
Copy link
Member Author

Notebook tests passed, still waiting for integration.

@RafalSkolasinski
Copy link
Member Author

@axsaucedo it seems that both integration and notebooks passed! 🚀

@axsaucedo
Copy link
Contributor

Nice one @RafalSkolasinski !

@axsaucedo axsaucedo merged commit b8cf277 into SeldonIO:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants