Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update version of operator in executor deps #2121

Merged
merged 2 commits into from
Jul 15, 2020
Merged

update version of operator in executor deps #2121

merged 2 commits into from
Jul 15, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski commented Jul 13, 2020 •
edited
Loading

Closes #2091
Closes #2134

Most changes in this PR are related to 3b4c990#diff-d7ca7b021e6d991a2ce6ffca9a69e42d in which PredictorSpec.PredictiveUnit stopped being a pointer.

This is because we bumped version as:
v0.0.0-20200401123312-d4c435ea5217 -> v0.0.0-20200713173314-b8a92914e17e

Update:
In last commit I explore possibility to use local copy of operator.

@RafalSkolasinski
Copy link
Contributor Author

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Mon Jul 13 17:15:22 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=1

@seldondev
Copy link
Collaborator

Mon Jul 13 17:15:25 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=2

@seldondev
Copy link
Collaborator

Mon Jul 13 17:16:50 UTC 2020
The logs for [notebooks] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=3

@seldondev
Copy link
Collaborator

Mon Jul 13 17:16:59 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=4

@RafalSkolasinski RafalSkolasinski force-pushed the issue/2091-executor-deps-upgrade-operator branch 2 times, most recently from a7aaa8f to 6b08ee4 Compare July 13, 2020 17:41
@seldondev
Copy link
Collaborator

Mon Jul 13 17:42:52 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=5

@seldondev
Copy link
Collaborator

Mon Jul 13 17:43:15 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=6

@seldondev
Copy link
Collaborator

Mon Jul 13 17:43:38 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=7

@seldondev
Copy link
Collaborator

Mon Jul 13 17:43:43 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=8

@RafalSkolasinski
Copy link
Contributor Author

/hold

I noticed that operator has go.uber.org/zap v1.10.0 but go.uber.org/zap v1.15.0 is available. Let's merge that into operator first. Opening PR shortly.

@RafalSkolasinski
Copy link
Contributor Author

After #2122 is merged I will update this PR.

@RafalSkolasinski RafalSkolasinski marked this pull request as draft July 13, 2020 18:23
@seldondev
Copy link
Collaborator

Tue Jul 14 09:51:54 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=10

@seldondev
Copy link
Collaborator

Tue Jul 14 09:51:56 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=9

@RafalSkolasinski RafalSkolasinski force-pushed the issue/2091-executor-deps-upgrade-operator branch from f17df2b to ee14258 Compare July 14, 2020 09:53
@seldondev
Copy link
Collaborator

Tue Jul 14 09:54:54 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=12

@seldondev
Copy link
Collaborator

Tue Jul 14 09:55:19 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=11

@RafalSkolasinski
Copy link
Contributor Author

/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Tue Jul 14 09:58:18 UTC 2020
The logs for [notebooks] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=13

@seldondev
Copy link
Collaborator

Tue Jul 14 09:58:49 UTC 2020
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=14

@seldondev
Copy link
Collaborator

Tue Jul 14 10:19:12 UTC 2020
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=16

@seldondev
Copy link
Collaborator

Tue Jul 14 10:19:43 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=15

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review July 14, 2020 14:01
@RafalSkolasinski
Copy link
Contributor Author

Executing tests again as they were garbage collected before I could take a look at results...
/test notebooks
/test integration

@seldondev
Copy link
Collaborator

Tue Jul 14 14:05:30 UTC 2020
The logs for [notebooks] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=17

@seldondev
Copy link
Collaborator

Tue Jul 14 14:05:42 UTC 2020
The logs for [integration] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=18

@RafalSkolasinski RafalSkolasinski force-pushed the issue/2091-executor-deps-upgrade-operator branch from 4a5276c to 4062573 Compare July 14, 2020 15:31
@RafalSkolasinski
Copy link
Contributor Author

RafalSkolasinski commented Jul 14, 2020 •
edited
Loading

Rebased on #2129 and should go after this one (as there most likely be a tiny merge conflict)

@seldondev
Copy link
Collaborator

Tue Jul 14 15:33:12 UTC 2020
The logs for [pr-build] [19] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/19.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=19

@seldondev
Copy link
Collaborator

Tue Jul 14 15:33:13 UTC 2020
The logs for [lint] [20] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/20.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=20

@RafalSkolasinski RafalSkolasinski force-pushed the issue/2091-executor-deps-upgrade-operator branch from 4062573 to c319070 Compare July 14, 2020 19:28
@RafalSkolasinski
Copy link
Contributor Author

/unhold

rebased on master as #2129 got merged

/test integration
/test notebooks

@seldondev
Copy link
Collaborator

Tue Jul 14 19:30:21 UTC 2020
The logs for [pr-build] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=21

@seldondev
Copy link
Collaborator

Tue Jul 14 19:30:28 UTC 2020
The logs for [lint] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=22

@seldondev
Copy link
Collaborator

Tue Jul 14 19:31:18 UTC 2020
The logs for [notebooks] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=23

@seldondev
Copy link
Collaborator

Tue Jul 14 19:31:36 UTC 2020
The logs for [integration] [24] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2121/24.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2121 --build=24

@RafalSkolasinski
Copy link
Contributor Author

/hold cancel

@RafalSkolasinski
Copy link
Contributor Author

Integrations passed. Waiting for notebooks.

@RafalSkolasinski
Copy link
Contributor Author

Notebooks passed as well!
Ready to landm @axsaucedo 🚀

@RafalSkolasinski RafalSkolasinski mentioned this pull request Jul 15, 2020
Closed
19 tasks
@RafalSkolasinski RafalSkolasinski requested review from ukclivecox and axsaucedo and removed request for ukclivecox July 15, 2020 08:29
@ukclivecox
Copy link
Contributor

/lgtm

@seldondev seldondev added the lgtm label Jul 15, 2020
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski
Copy link
Contributor Author

Initiating manual merge as tests passed but their status on Github didn't get updated.

@RafalSkolasinski RafalSkolasinski merged commit 31f2cac into SeldonIO:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axsaucedo axsaucedo Awaiting requested review from axsaucedo

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

Assignees

@ukclivecox ukclivecox

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade k8s.io dependencies in the Executor Upgrade Operator version in Executor deps
3 participants
@RafalSkolasinski @seldondev @ukclivecox