Nodejs s2i wrapper for JavaScript models #218

SachinVarghese · 2018-09-08T18:55:59Z

Creating a pull request for the implementation of Nodejs s2i wrapper for JavaScript models as per issue #216 .

Created an example node tensorflow js model
Standardized a pattern for js models as an ES5 function object or an ES6 class
Added the dockerfile for the creation of the nodejs s2i wrapper image

SachinVarghese · 2018-09-09T15:20:55Z

Also while I was at it, I tried deploying an R model. I found that the s2i environment required as per the R wrapper s2i env docs doesn't work. The parameter model name has to have the file extension also to make it work. For instance,in the s2i/environment file, MODEL_NAME=MyModel.R

Should I add this minor change as a part of this request or create a separate one?

SachinVarghese · 2018-09-09T16:37:32Z

Also fixing the issue in the R wrapper documentation as per issue #219

ukclivecox

Running the steps in the Readme after installing nodejs I get an error on the last part npm run predict:

2018-09-09 17:42:51.698991: I tensorflow/core/platform/cpu_feature_guard.cc:141] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
(node:32104) Warning: N-API is an experimental feature and could change at any time.
Predicting ...
(node:32104) UnhandledPromiseRejectionWarning: TypeError: predict.print is not a function
    at run (/home/clive/work/seldon-core/fork-seldon-core/examples/models/nodejs_tensorflow/predict.js:18:11)
    at <anonymous>
(node:32104) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:32104) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

examples/models/nodejs_tensorflow/package.json

ukclivecox · 2018-09-09T16:46:21Z

Can you also add more documentation for the example explaining what it will do. Also, said a notebook for the steps would follow the existing examples.

…ample

SachinVarghese · 2018-09-09T17:16:16Z

@cliveseldon I have made some necessary changes including the explanation of the model example.
Also, I am planning to add a better model example as the current example is only a test model and is not very relevant as a real-world application. Later, I can get started on the notebook as planned. Also I plan to create a new issue for gRPC support for the same.

Can you please review the update. Thanks a lot!

ukclivecox · 2018-09-09T17:22:13Z

The changes look good. So I think what is still needed is:

A Makefile in the wrapper/s2i/nodejs folder following the other language examples that creates and pushes the image. (once this is added I can run this from your fork to push an image to our repo)
A Makefile in the examples folder that cleans up the extra files created during testing
A notebook showing the example with use of s2i and a seldon deployment running in Minikube and tested using the tester python modules. You should take an example notebook from the other examples as a base.

This reverts commit 97ee94a.

SachinVarghese · 2018-09-09T17:59:21Z

@cliveseldon I have added the makefiles for both the example model and the wrapper. You may review them.
About the ipython notebook, I need your opinion on whether this test example model is an appropriate choice for the top level readme, or we should create a better model example that is more relevant as a real-world application. I think this can be a different issue. Need your thoughts here. Thanks.

SachinVarghese · 2018-09-09T19:39:35Z

@cliveseldon I have added the ipython notebook. Let me know if something else can be improved.
Also I need your thoughts on the suggestion for an improved example at the top level readme as a different issue.

ukclivecox

It would be ideal to have a real example based on a standard dataset. So forexample, the Iris data set or MNIST. There are other examples that use these. Are there not any examples that people have provided for tensorflow_js that can easily be used?

ukclivecox · 2018-09-10T06:52:09Z

wrappers/s2i/nodejs/Makefile

+
+
+.PHONY: test
+test:


make test does not work:

make test docker build -t docker.io/seldonio/seldon-core-s2i-nodejs:0.1-candidate . Sending build context to Docker daemon 25.6kB Step 1/9 : FROM node:latest ---> d0d12094f6ab Step 2/9 : LABEL io.openshift.s2i.scripts-url="image:///s2i/bin" ---> Using cache ---> aaef67401575 Step 3/9 : RUN mkdir microservice ---> Using cache ---> 6cfa93b61811 Step 4/9 : WORKDIR /microservice ---> Using cache ---> 4dffc6d86792 Step 5/9 : COPY microservice.js /microservice ---> Using cache ---> 318f520dc0a0 Step 6/9 : COPY package.json /microservice ---> Using cache ---> 42dcbdf715b9 Step 7/9 : RUN npm install ---> Using cache ---> 9f165e8ab34b Step 8/9 : COPY ./s2i/bin/ /s2i/bin ---> Using cache ---> 8f075578815b Step 9/9 : EXPOSE 5000 ---> Using cache ---> bd7b6e6f5275 Successfully built bd7b6e6f5275 Successfully tagged seldonio/seldon-core-s2i-nodejs:0.1-candidate IMAGE_NAME=docker.io/seldonio/seldon-core-s2i-nodejs:0.1-candidate test/run /bin/sh: 1: test/run: not found Makefile:17: recipe for target 'test' failed

The recipe failed because it couldn't find the appropriate run file within the test folder which is present now. So this should be working now. Please review. Thanks.

…ample

ukclivecox · 2018-09-14T14:37:58Z

You seem to have an editor which is changing all the markdown from * to -, can you redo it so only your change is made and we use * ?

SachinVarghese · 2018-09-14T14:48:59Z

Ok, this is done. Can you confirm?

ukclivecox · 2018-09-13T10:32:23Z

wrappers/s2i/nodejs/package.json

+    "test": "echo \"Error: no test specified\" && exit 1"
+  },
+  "author": "SachinVarghese",
+  "license": "ISC",


You need to change this to Apache 2 to fit with Seldon Core license

ukclivecox · 2018-09-14T10:01:38Z

wrappers/s2i/nodejs/microservice.js

+    args.service,
+    args.persistence
+  );
+  console.log("NodeJs Microservice listening on port 5000!");


port is hardwired here.

ukclivecox · 2018-09-14T10:01:54Z

wrappers/s2i/nodejs/microservice.js

+      result = array_to_rest_data(result, body);
+      res.status(200).send(result);
+    } else {
+      res.status(500).send(predict);


Please add console messages as well on error.

ukclivecox · 2018-09-14T10:02:09Z

wrappers/s2i/nodejs/microservice.js

+      body = JSON.parse(req.body.json);
+      body = body.data;
+    } catch (msg) {
+      res.status(500).send("Cannot parse predict input json " + req.body.json);


Please add console message as well on error.

ukclivecox · 2018-09-14T15:08:26Z

Thanks for all your hard work on this. I think this is ready to merge.

SachinVarghese · 2018-09-14T15:10:57Z

Thanks for your patience and testing multiple times. I will try to make it easier for you next time around.
Hope this helps.

Sachin.Varghese added 8 commits September 8, 2018 15:46

Adding nodejs warapper

75a73fc

nodejs wrapper v1

ddb9d0e

minor update

7272bb8

minor update to run s2i script

f65ae8a

Adding Documentation

ba19275

Adding Documentation to node tensorflow example

bad2cc4

updating the microservice srcipt and ES6 class docs

e9f4c11

changes to the examples to follow the API output pattern

454f891

optimizing the model load and update docs

921dfae

Fixing issue SeldonIO#219

97ee94a

ukclivecox suggested changes Sep 9, 2018

View reviewed changes

examples/models/nodejs_tensorflow/package.json Outdated Show resolved Hide resolved

Updating the predict function and adding explanation for the model ex…

ceecdbd

…ample

Sachin.Varghese added 3 commits September 9, 2018 22:53

Revert "Fixing issue SeldonIO#219"

974f26f

This reverts commit 97ee94a.

Creating Makefiles for testing the model

b58e8a9

Creating Makefiles for testing the wrapper

973087b

Sachin.Varghese added 5 commits September 10, 2018 00:31

Adding example Nodejs Tensorflow model ipython notebook

3645096

Tensorflow model ipython notebook update

b172b21

Tensorflow model ipython notebook update

aa31c8d

Tensorflow model ipython notebook update

d5826ef

Tensorflow model ipython notebook update

6407a56

ukclivecox suggested changes Sep 10, 2018

View reviewed changes

Sachin.Varghese added 2 commits September 10, 2018 15:24

Adding Test run files

5b54099

Adding docs for testing the image

f7d3505

Sachin.Varghese added 20 commits September 14, 2018 20:02

Updating the predict function and adding explanation for the model ex…

4969d98

…ample

Creating Makefiles for testing the model

bc2f95b

Creating Makefiles for testing the wrapper

42d62db

Adding example Nodejs Tensorflow model ipython notebook

c2b231c

Tensorflow model ipython notebook update

0b6aca5

Tensorflow model ipython notebook update

e7cb117

Tensorflow model ipython notebook update

46420ff

Tensorflow model ipython notebook update

85b9333

Adding Test run files

7c901c4

Adding docs for testing the image

9e7e38c

Adding MNIST example

043b21d

Update image test and nodejs mnist example predict command

b9f8d98

updating nodejs MNIST make file and contract.json

defd7ca

Updating notebooks and other examples

429ad5e

Updating notebooks with minikube examples

4cfeb41

Updating the license to Apache 2.0

bbc0af6

using environment variable for microservice port

c7ee34b

Logging message update to correct port

bc732c0

Updating microservice return data and example notebooks

0c2af38

Adding Logs in the event of 500 error

353e7ce

Sachin.Varghese added 2 commits September 14, 2018 20:14

update README

90c9d30

update README

c1c1ada

ukclivecox approved these changes Sep 14, 2018

View reviewed changes

ukclivecox merged commit 459811f into SeldonIO:master Sep 14, 2018

SachinVarghese deleted the issue-216 branch September 14, 2018 15:11

snyk-bot mentioned this pull request Jul 30, 2020

[Snyk] Upgrade @tensorflow/tfjs-node from 0.1.15 to 0.3.2 #2215

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nodejs s2i wrapper for JavaScript models #218

Nodejs s2i wrapper for JavaScript models #218

SachinVarghese commented Sep 8, 2018

SachinVarghese commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018 •

edited

Loading

ukclivecox left a comment

ukclivecox commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018 •

edited

Loading

ukclivecox commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018

ukclivecox left a comment

ukclivecox Sep 10, 2018

SachinVarghese Sep 13, 2018

ukclivecox commented Sep 14, 2018

SachinVarghese commented Sep 14, 2018

ukclivecox Sep 13, 2018

ukclivecox Sep 14, 2018

ukclivecox Sep 14, 2018

ukclivecox Sep 14, 2018

ukclivecox commented Sep 14, 2018

SachinVarghese commented Sep 14, 2018



		.PHONY: test
		test:

Nodejs s2i wrapper for JavaScript models #218

Nodejs s2i wrapper for JavaScript models #218

Conversation

SachinVarghese commented Sep 8, 2018

SachinVarghese commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018 • edited Loading

ukclivecox left a comment

Choose a reason for hiding this comment

ukclivecox commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018 • edited Loading

ukclivecox commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018

SachinVarghese commented Sep 9, 2018

ukclivecox left a comment

Choose a reason for hiding this comment

ukclivecox Sep 10, 2018

Choose a reason for hiding this comment

SachinVarghese Sep 13, 2018

Choose a reason for hiding this comment

ukclivecox commented Sep 14, 2018

SachinVarghese commented Sep 14, 2018

ukclivecox Sep 13, 2018

Choose a reason for hiding this comment

ukclivecox Sep 14, 2018

Choose a reason for hiding this comment

ukclivecox Sep 14, 2018

Choose a reason for hiding this comment

ukclivecox Sep 14, 2018

Choose a reason for hiding this comment

ukclivecox commented Sep 14, 2018

SachinVarghese commented Sep 14, 2018

SachinVarghese commented Sep 9, 2018 •

edited

Loading

SachinVarghese commented Sep 9, 2018 •

edited

Loading