Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python test microservice flakiness #2336

Merged
merged 2 commits into from
Aug 28, 2020
Merged

fix python test microservice flakiness #2336

merged 2 commits into from
Aug 28, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

What this PR does / why we need it:

Send SIGKILL to test microservice spawn as subprocess to make sure that it is killed after the test.

Which issue(s) this PR fixes:

Closes #2293
Closes #1745

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@RafalSkolasinski RafalSkolasinski marked this pull request as draft August 27, 2020 13:49
@seldondev
Copy link
Collaborator

Thu Aug 27 13:49:47 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=2

@seldondev
Copy link
Collaborator

Thu Aug 27 13:50:01 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=1

@RafalSkolasinski
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Thu Aug 27 14:06:54 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=3

@RafalSkolasinski
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Thu Aug 27 14:22:38 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=4

@RafalSkolasinski
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Thu Aug 27 14:55:05 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=5

@seldondev
Copy link
Collaborator

Thu Aug 27 15:03:03 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=6

@seldondev
Copy link
Collaborator

Thu Aug 27 15:03:13 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=7

@RafalSkolasinski
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Thu Aug 27 15:28:46 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=8

@RafalSkolasinski
Copy link
Contributor Author

/test this

@seldondev
Copy link
Collaborator

Thu Aug 27 15:48:42 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=9

@RafalSkolasinski
Copy link
Contributor Author

last one
/test this

@seldondev
Copy link
Collaborator

Thu Aug 27 16:18:54 UTC 2020
The logs for [pr-build] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2336/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2336 --build=10

@RafalSkolasinski
Copy link
Contributor Author

@axsaucedo this passed many times - I think it's ready to merge :)

@RafalSkolasinski RafalSkolasinski marked this pull request as ready for review August 27, 2020 16:42
@axsaucedo
Copy link
Contributor

Nice one - change looks quite reasonable, looks good as a fix for flakiness for now.
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RafalSkolasinski RafalSkolasinski merged commit 043cf86 into SeldonIO:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants