-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix python test microservice flakiness #2336
fix python test microservice flakiness #2336
Conversation
Thu Aug 27 13:49:47 UTC 2020 impatient try |
Thu Aug 27 13:50:01 UTC 2020 impatient try |
/test this |
Thu Aug 27 14:06:54 UTC 2020 impatient try |
/test this |
Thu Aug 27 14:22:38 UTC 2020 impatient try |
/test this |
Thu Aug 27 14:55:05 UTC 2020 impatient try |
Thu Aug 27 15:03:03 UTC 2020 impatient try |
Thu Aug 27 15:03:13 UTC 2020 impatient try |
/test this |
Thu Aug 27 15:28:46 UTC 2020 impatient try |
/test this |
Thu Aug 27 15:48:42 UTC 2020 impatient try |
last one |
Thu Aug 27 16:18:54 UTC 2020 impatient try |
@axsaucedo this passed many times - I think it's ready to merge :) |
Nice one - change looks quite reasonable, looks good as a fix for flakiness for now. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Send SIGKILL to test microservice spawn as subprocess to make sure that it is killed after the test.
Which issue(s) this PR fixes:
Closes #2293
Closes #1745
Special notes for your reviewer:
Does this PR introduce a user-facing change?: