-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sklearn_spacy_text_classifier_example.ipynb #2487
Update sklearn_spacy_text_classifier_example.ipynb #2487
Conversation
Missing `",` at line 460, rendered notebook unusable without it
Hi @Syakyr. Thanks for your PR. I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
/assign @axsaucedo |
/ok-to-test |
nice catch, /approve |
Mon Sep 28 12:17:24 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Mon Sep 28 12:18:00 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Tue Sep 29 10:14:40 UTC 2020 impatient try |
Tue Sep 29 10:15:59 UTC 2020 impatient try |
Missing
",
at line 460, rendered notebook unusable without itWhat this PR does / why we need it:
Added
",
at line 460 for the specified notebook, otherwise notebook is rendered unusable.Which issue(s) this PR fixes:
Fixes #2486
Special notes for your reviewer:
NA
Does this PR introduce a user-facing change?: