Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sklearn_spacy_text_classifier_example.ipynb #2487

Conversation

Syakyr
Copy link
Contributor

@Syakyr Syakyr commented Sep 25, 2020

Missing ", at line 460, rendered notebook unusable without it

What this PR does / why we need it:
Added ", at line 460 for the specified notebook, otherwise notebook is rendered unusable.

Which issue(s) this PR fixes:

Fixes #2486

Special notes for your reviewer:
NA

Does this PR introduce a user-facing change?:

Fixes sklearn_spacy_text_classifier_example.ipynb to be readable

Missing `",` at line 460, rendered notebook unusable without it
@seldondev
Copy link
Collaborator

Hi @Syakyr. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Syakyr
Copy link
Contributor Author

Syakyr commented Sep 25, 2020

/assign @axsaucedo

@RafalSkolasinski
Copy link
Contributor

/ok-to-test

@RafalSkolasinski
Copy link
Contributor

nice catch, /approve

@seldondev
Copy link
Collaborator

Mon Sep 28 12:17:24 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2487/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2487 --build=2

Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@seldondev
Copy link
Collaborator

Mon Sep 28 12:18:00 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2487/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2487 --build=1

@RafalSkolasinski
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Sep 29 10:14:40 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2487/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2487 --build=3

@seldondev
Copy link
Collaborator

Tue Sep 29 10:15:59 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2487/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2487 --build=4

@seldondev seldondev merged commit 4b29994 into SeldonIO:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreadable notebook - sklearn_spacy_text_classifier_example.ipynb
4 participants