Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/controller-runtime from 0.6.2 to 0.6.3 in /executor #2490

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Sep 28, 2020

Bumps sigs.k8s.io/controller-runtime from 0.6.2 to 0.6.3.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.6.3

Changes since v0.6.2

馃悰 Bug Fixes

  • Controller.Watch() should not store watches if already started (#1165)

馃尡 Others

  • Update json-patch to v4.9.0 (#1137)

Thanks to all our contributors! 馃槉

Commits
  • ac380d6 Merge pull request #1165 from vincepri/backpor06-1163
  • 78d0026 馃悰 Controller.Watch() should not store watches if already started
  • 29c2e32 Merge pull request #1137 from vincepri/update-jsonpatch490-06
  • 50d7d20 馃尡 Update json-patch to v4.9.0
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 28, 2020
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@adriangonz
Copy link
Contributor

/ok-to-test

@seldondev
Copy link
Collaborator

Mon Sep 28 08:08:54 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=1

@seldondev
Copy link
Collaborator

Mon Sep 28 08:08:56 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=2

@adriangonz
Copy link
Contributor

Linter issues should get fixed by #2496

@adriangonz
Copy link
Contributor

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/go_modules/executor/sigs.k8s.io/controller-runtime-0.6.3 branch from 6d54362 to 2ec3faf Compare September 28, 2020 13:57
@seldondev
Copy link
Collaborator

Mon Sep 28 13:59:56 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=3

@seldondev
Copy link
Collaborator

Mon Sep 28 13:59:58 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=4

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Sep 29 08:47:01 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=5

@seldondev
Copy link
Collaborator

@dependabot-preview[bot]: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 2ec3faf link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@adriangonz
Copy link
Contributor

The failing test was a flaky one.

@adriangonz
Copy link
Contributor

/approve

Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.6.2 to 0.6.3.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Commits](kubernetes-sigs/controller-runtime@v0.6.2...v0.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/go_modules/executor/sigs.k8s.io/controller-runtime-0.6.3 branch from 2ec3faf to 73c6f1a Compare September 29, 2020 13:13
@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Tue Sep 29 13:15:38 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=7

@seldondev
Copy link
Collaborator

Tue Sep 29 13:15:40 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2490/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2490 --build=6

@seldondev seldondev merged commit 7eb3451 into master Sep 29, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/go_modules/executor/sigs.k8s.io/controller-runtime-0.6.3 branch September 29, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file go Pull requests that update Go code ok-to-test size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants